Skip to content
Snippets Groups Projects

Compress_block_log + artifacts changes.

Merged Andrzej Such requested to merge as-artifacts-problems into develop
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dan Notestein
  • Andrzej Such added 2 commits

    added 2 commits

    • 41dc9232 - Update log in verify_if_blocks_from_block_log_matches_artifact
    • 9c178601 - Update assert's log in verify_if_blocks_from_block_log_matches_artifacts

    Compare with previous version

  • Andrzej Such added 2 commits

    added 2 commits

    • f4332aaf - Fix block_log_artifacts::impl::open - generate blocks only if we have a...
    • f0a044d5 - Modify a way how compress_block_log handles exceptions if any occurs in input block_log

    Compare with previous version

  • Andrzej Such changed title from As artifacts problems to Compress_block_log + artifacts changes.

    changed title from As artifacts problems to Compress_block_log + artifacts changes.

  • Andrzej Such added 2 commits

    added 2 commits

    • 752f0b91 - Modify a way how compress_block_log handles exceptions.
    • c29df6a8 - In case if artifacts file head block num is 0 and block_log contains blocks,...

    Compare with previous version

    • Resolved by Bartek Wrona

      This wording you wrote: Cannot verify if artifacts file matches block_log. The range of blocks to check tries to read artifacts which are have not been generated yet.

      seems better than before, but is still a bit unclear to me. Is this causing a failure due to the mismatch in the number of blocks? Or is it just warning that the operation will take a bit longer in order to generate missing artifacts? I guess it would help if I know if the requested operation is to just check that the two files are consistent, or if the requested operation is bring the two files into consistency if possible.

  • Bartek Wrona
  • Andrzej Such added 15 commits

    added 15 commits

    • c29df6a8...f65951c2 - 8 commits from branch develop
    • 15149e2b - In compress_block_log, show current_block_number if error occurs in fill_pending_queue
    • 314765df - Update log in verify_if_blocks_from_block_log_matches_artifact
    • 2d409746 - Update assert's log in verify_if_blocks_from_block_log_matches_artifacts
    • 8631ead6 - Fix block_log_artifacts::impl::open - generate blocks only if we have a...
    • 236287dd - Modify a way how compress_block_log handles exceptions.
    • eef89e5e - In case if artifacts file head block num is 0 and block_log contains blocks,...
    • b1900bfa - compress_block_log - add a function wrapper which will handle exceptions for all threads

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 4766ddef - compress_block_log - add a function wrapper which will handle exceptions for all threads

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 1bd5b43e - compress_block_log - add a function wrapper which will handle exceptions for all threads

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • a5f92e6b - compress_block_log - add a function wrapper which will handle exceptions for all threads

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 89a021de - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 6ad03615 - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 76158386 - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • cd21e3fa - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • db5ae2bd - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 60a439b0 - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 3d8dfe36 - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 7d4df545 - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 5cbb7b08 - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 11c9e109 - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 332113d6 - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • f410503e - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 7f71e4c0 - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Bartek Wrona
  • Bartek Wrona
  • Bartek Wrona
  • Bartek Wrona
  • Bartek Wrona
  • Bartek Wrona
  • Andrzej Such added 22 commits

    added 22 commits

    • 7f71e4c0...f78ff8c4 - 12 commits from branch develop
    • 556975b2 - In compress_block_log, show current_block_number if error occurs in fill_pending_queue
    • 18c0b358 - Update log in verify_if_blocks_from_block_log_matches_artifact
    • 4ffd4450 - Update assert's log in verify_if_blocks_from_block_log_matches_artifacts
    • 48891f96 - Fix block_log_artifacts::impl::open - generate blocks only if we have a...
    • 5627f9de - Modify a way how compress_block_log handles exceptions.
    • f38b7975 - In case if artifacts file head block num is 0 and block_log contains blocks,...
    • 71b35bd4 - compress_block_log - add a function wrapper which will handle exceptions for all threads
    • f4410ec9 - Prepare simple tests for artifacts generation process.
    • b683ec6e - test_artifacts_generation.sh accepts path to hived binary, instead of...
    • 5c54b986 - Use lambdas instead of std::bind in compress_block_log + small changes requested in MR.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 4780643f - Use lambdas instead of std::bind in compress_block_log + small changes requested in MR.

    Compare with previous version

  • Andrzej Such added 1 commit

    added 1 commit

    • 68429097 - Use lambdas instead of std::bind in compress_block_log + small changes requested in MR.

    Compare with previous version

  • Andrzej Such added 25 commits

    added 25 commits

    • 68429097...ecc9ca77 - 15 commits from branch develop
    • fe6704e1 - In compress_block_log, show current_block_number if error occurs in fill_pending_queue
    • fb100d91 - Update log in verify_if_blocks_from_block_log_matches_artifact
    • 68946096 - Update assert's log in verify_if_blocks_from_block_log_matches_artifacts
    • 78a624c0 - Fix block_log_artifacts::impl::open - generate blocks only if we have a...
    • 3b66a766 - Modify a way how compress_block_log handles exceptions.
    • d7910a8c - In case if artifacts file head block num is 0 and block_log contains blocks,...
    • 2acaa5f7 - compress_block_log - add a function wrapper which will handle exceptions for all threads
    • 03c7665e - Prepare simple tests for artifacts generation process.
    • 7ec9fccc - test_artifacts_generation.sh accepts path to hived binary, instead of...
    • 9050a588 - Use lambdas instead of std::bind in compress_block_log + small changes requested in MR.

    Compare with previous version

  • Bartek Wrona added 14 commits

    added 14 commits

    • 9050a588...a992f6a3 - 4 commits from branch develop
    • 20fec904 - In compress_block_log, show current_block_number if error occurs in fill_pending_queue
    • 358b55a8 - Update log in verify_if_blocks_from_block_log_matches_artifact
    • afe72a60 - Update assert's log in verify_if_blocks_from_block_log_matches_artifacts
    • 88201e69 - Fix block_log_artifacts::impl::open - generate blocks only if we have a...
    • 582eb789 - Modify a way how compress_block_log handles exceptions.
    • cf238af7 - In case if artifacts file head block num is 0 and block_log contains blocks,...
    • 9c466f5d - compress_block_log - add a function wrapper which will handle exceptions for all threads
    • ed08443c - Prepare simple tests for artifacts generation process.
    • ba9c9ec0 - test_artifacts_generation.sh accepts path to hived binary, instead of...
    • c12ce57f - Use lambdas instead of std::bind in compress_block_log + small changes requested in MR.

    Compare with previous version

  • Bartek Wrona added 6 commits

    added 6 commits

    • 0dc995d2 - Update block_log.artifacts & block_log files verification messages
    • 73d591bd - Fix block_log_artifacts::impl::open - generate blocks only if we have a...
    • ff8408aa - Modify a way how compress_block_log handles exceptions.
    • 2279c8bf - In case if artifacts file head block num is 0 and block_log contains blocks,...
    • 1ebbac53 - compress_block_log - use a common function wrapper to handle exceptions for all threads
    • f3032e4e - Prepare simple tests for artifacts generation process.

    Compare with previous version

  • Bartek Wrona resolved all threads

    resolved all threads

  • Bartek Wrona enabled an automatic merge when the pipeline for f3032e4e succeeds

    enabled an automatic merge when the pipeline for f3032e4e succeeds

  • merged

  • Bartek Wrona mentioned in merge request !1001 (merged)

    mentioned in merge request !1001 (merged)

  • Please register or sign in to reply
    Loading