Fix WitnessSetPropertiesOperation schema
There was a typo sbd
instead of hbd
which caused:
ValidationError: 2 validation errors for JSONRPCResult[GetAccountHistoryModel[Hf26ApiOperationObject, Hf26ApiVirtualOperationObject]]
result -> history -> 0 -> 1 -> op -> WitnessSetPropertiesHF26OperationRepresentation -> value -> props -> 0 -> 0
unexpected value; permitted: 'account_creation_fee', 'account_subsidy_budget', 'account_subsidy_decay', 'key', 'maximum_block_size',
'new_signing_key', 'sbd_exchange_rate', 'sbd_interest_rate', 'url' (type=value_error.const; given=hbd_exchange_rate;
permitted=('account_creation_fee', 'account_subsidy_budget', 'account_subsidy_decay', 'key', 'maximum_block_size', 'new_signing_key',
'sbd_exchange_rate', 'sbd_interest_rate', 'url'))
Ft.: clive#268 (closed)
Merge request reports
Activity
requested review from @kmochocki
assigned to @mzebrak
added 2 commits
- Resolved by Krzysztof Mochocki
@rmaslowski do you remember or know if this change (from sbd to hbd) will crash tests in hive, because i remember that you've made related changes in hive MR and in your schema MR?
mentioned in merge request !90 (merged)
assigned to @rmaslowski and unassigned @mzebrak
added 12 commits
-
0526bb76...f4fdcfe4 - 10 commits from branch
master
- ff595f78 - Add regression test
- a2ffb69a - Fix typo sbd -> hbd
-
0526bb76...f4fdcfe4 - 10 commits from branch
mentioned in merge request helpy!62 (closed)
requested review from @mzebrak and removed review request for @kmochocki
Schemas must include backward compatibility and support both 'sbd' and 'hbd' literals. The reason can be found in the hived code: https://gitlab.syncad.com/hive/hive/-/blob/4913627cf74cf0dd9d65476ab101042ba5a4239d/libraries/chain/hive_evaluator.cpp#L158
I’m closing the merge request.
Edited by Radosław Masłowski