Release v1.27.5.16

Closes: %Release v1.27.5.16

1. New features/functions

   • Add "Bad account" feature preventing making some actions to account considered as bad/malicious - #239 (closed) via !473 (merged)
     • List cannot be modified via TUI/CLI, but can be observed on the Accounts Management screen
   • Support for both positional and named option parameters for clive show / clive configure subcommand tree - #256 (closed) via !461 (merged)

2. Functional improvements

   • Rework cart - #173 (closed) via !388 (merged)
     • Removed "Clear all" feature from the cart as it's uncommon to remove all operations and could be pressed by mistake
     • Speedup
     • Better focus handling
     • Consistent look with other tables
   • Speedup HTTP communication - #42 (closed) via !470 (merged)
   • Consistent look of focused button (white instead of white/black) - #225 (closed) via !474 (merged)
   • Consistent look of dialog screens - #273 (closed) via !462 (merged)
   • Change how the "Known account" works, no more checkbox, account is added to the list after action and not in-place on the screen - #238 (closed) via !467 (merged)
   • Some of the exceptions will be "pretty" in CLI, like it is in TUI - !460 (merged)
   • Group operation-common options in the CLI help - !481 (c925a1ea)
   • Remove "Switch working account" tab from Account management screen as this action can be done via header - !481 (5e2c8f5d)

3. Bugfixes

   • Fix app closure when launched via TUI .sh script and signal handling - #274 (closed) via !465 (merged)
   • Fix pushing multiple account details screens to the screen stack - !468 (merged)
   • Fix message when entering operations without tracked accounts - !478 (merged)
   • Fix displaying witness/proposal votes when there are operations from different working account in the cart - !471 (merged)
   • Fix visual effect of wrong margin when input validation result is displayed - !481 (af5938e4)
   • Fix clive configure key add cannot run when no explicit --alias was given - !481 (68f82f1e)

clive/__private/ui/screens/config/account_management/bad_accounts.py

@@ -16,7 +16,6 @@ from clive.__private.ui.widgets.clive_basic import (
     CliveCheckerboardTableRow,
 )
 from clive.__private.ui.widgets.inputs.account_name_pattern_input import AccountNamePatternInput
-from clive.__private.ui.widgets.no_content_available import NoContentAvailable
 from clive.__private.ui.widgets.scrolling import ScrollablePart
 from clive.__private.ui.widgets.section_title import SectionTitle
 
@@ -101,7 +100,7 @@ class BadAccountsTable(CliveCheckerboardTable):
         if self._current_page_index <= self.FIRST_PAGE_INDEX:
             self._page_up_button.visible = False
 
-        await self._rebuild_rows()
+        await self.rebuild_rows()
 
     @on(PageDownButton.Pressed)
     async def action_next_page(self) -> None:
@@ -114,7 +113,7 @@ class BadAccountsTable(CliveCheckerboardTable):
         if self._current_page_index >= self._last_page_index:
             self._page_down_button.visible = False
 
-        await self._rebuild_rows()
+        await self.rebuild_rows()
 
     async def set_search_mode(self, pattern: str) -> None:
         pattern = rf"^{pattern}"
@@ -135,28 +134,10 @@ class BadAccountsTable(CliveCheckerboardTable):
     async def _reset_table(self) -> None:
         self._current_page_index = self.FIRST_PAGE_INDEX
         self._last_page_index = self._get_last_page_index()
+
         self._page_up_button.visible = False
         self._page_down_button.visible = True
-
-        await self._rebuild_rows()
-
-    async def _rebuild_rows(self) -> None:
-        with self.app.batch_update():
-            await self._remove_rows()
-            await self._mount_new_rows()
-
-    async def _remove_rows(self) -> None:
-        await self.query(CliveCheckerboardTableRow).remove()
-        await self.query(NoContentAvailable).remove()
-
-    async def _mount_new_rows(self) -> None:
-        if len(self._bad_account_names) == 0:
-            await self.mount(NoContentAvailable("No bad accounts found with this pattern"))
-            return
-
-        new_rows = self.create_static_rows()
-        self._set_evenness_styles(new_rows)
-        await self.mount_all(new_rows)
+        await self.rebuild_rows()
 
 
 class BadAccounts(TabPane):