Refactor Cart into checkerboard table
Closes: #173 (closed)
Removes clear all feature from: #233
This one improves focus behavior in the cart, moving cart items and deleting items from the cart.
Merge request reports
Activity
mentioned in merge request !382 (merged)
assigned to @mkudela
added Topic::TUI label
Resolved by Mateusz ŻebrakAs mentioned IRL this version of the cart is slower than the previous one (could be checked when there are e.g. 30 witness vote operations in the cart and we try to change position of one of them).
We should work on the cart in the direction of not rebuilding entire table as it is right now, but on move recreate only 2 rows of the table, and on delete remove a single row and update indexes of the rest of rows. Also maybe you wont have to call something like table.update_indexes() if reactive was used there so it will observe other reactive of profile_data and update indexes automatically if change in profile data occurs. See also https://textual.textualize.io/guide/reactivity/#data-binding and maybe https://textual.textualize.io/guide/reactivity/#compute-methods
- Last reply by Mateusz Kudela
- Resolved by Mateusz Żebrak
ctrl+up and ctrl+down doesn't work in this version (it was used to quickly move between rows)
- Last reply by Mateusz Kudela
added 35 commits
-
0b5a650b...ff85d26c - 34 commits from branch
develop - e3793db4 - Refactor Cart into checkerboard table
-
0b5a650b...ff85d26c - 34 commits from branch
added 77 commits
-
eba1bbc0...e254441d - 75 commits from branch
develop - b00a89ae - Add optional start and end index to rebuild method
- 92b06c9c - Refactor Cart into checkerboard table
-
eba1bbc0...e254441d - 75 commits from branch
added 7 commits
-
6ae3e4d4...60ac049b - 5 commits from branch
develop - d024e985 - Add support for rebuilding part of checkerboard table
- 5de823c5 - Refactor Cart into checkerboard table
-
6ae3e4d4...60ac049b - 5 commits from branch
added 9 commits
-
5de823c5...14238843 - 7 commits from branch
develop - bc35654b - Add support for rebuilding part of checkerboard table
- efc05e51 - Refactor Cart into checkerboard table
-
5de823c5...14238843 - 7 commits from branch
added 5 commits
-
c406ffb7...6f7c0f3b - 3 commits from branch
develop - 9c334128 - Add support for rebuilding part of checkerboard table
- 590e68a3 - Refactor Cart into checkerboard table
-
c406ffb7...6f7c0f3b - 3 commits from branch
added 12 commits
-
590e68a3...4918bd8f - 10 commits from branch
develop - 6eda25c6 - Add support for rebuilding part of checkerboard table
- 793370ab - Refactor Cart into checkerboard table
-
590e68a3...4918bd8f - 10 commits from branch
After _mount_static_rows changes its behavior, I think if the table is not dynamic, we should do:
self._mount_all(self._create_table_content)in compose.Edited by Jakub Ziebinskiadded 35 commits
-
046af606...603d9647 - 31 commits from branch
develop - 21b04311 - Add support for rebuilding part of checkerboard table
- a4180949 - Add update_content method to CliveCheckerboardTableCell
- d131422a - Make set_evenness_styles public, remove cell classes before adding them
- 70eab283 - Refactor Cart into checkerboard table
Toggle commit list-
046af606...603d9647 - 31 commits from branch
added 15 commits
-
bd757121...adbde7ad - 11 commits from branch
develop - 161fedf7 - Add support for rebuilding part of checkerboard table
- 77af3417 - Add update_content method to CliveCheckerboardTableCell
- e6d3309d - Make set_evenness_styles public, remove cell classes before adding them
- fe1681f7 - Refactor Cart into checkerboard table
Toggle commit list-
bd757121...adbde7ad - 11 commits from branch
added 53 commits
-
fe1681f7...018c1e47 - 49 commits from branch
develop - 4acee765 - Add support for rebuilding part of checkerboard table
- fd318aad - Add update_content method to CliveCheckerboardTableCell
- 032feccc - Make set_evenness_styles public, remove cell classes before adding them
- 921fa588 - Refactor Cart into checkerboard table
Toggle commit list-
fe1681f7...018c1e47 - 49 commits from branch
added 12 commits
-
921fa588...016963c6 - 8 commits from branch
develop - 4bb6462b - Add support for rebuilding part of checkerboard table
- 8292da79 - Add update_content method to CliveCheckerboardTableCell
- 2e6b4b84 - Make set_evenness_styles public, remove cell classes before adding them
- f52bea76 - Refactor Cart into checkerboard table
Toggle commit list-
921fa588...016963c6 - 8 commits from branch
added 18 commits
-
f52bea76...59cd0b81 - 14 commits from branch
develop - 9ee24124 - Add support for rebuilding part of checkerboard table
- 217b76cf - Add update_content method to CliveCheckerboardTableCell
- dac9dd40 - Make set_evenness_styles public, remove cell classes before adding them
- 7797442c - Refactor Cart into checkerboard table
Toggle commit list-
f52bea76...59cd0b81 - 14 commits from branch
added 1 commit
- 825f0e93 - WIP UPDATE ROWS INSTEAD OF REBUILDING ON SWAP
added 7 commits
-
f283c50c - 1 commit from branch
develop - d6096602 - Add support for rebuilding part of checkerboard table
- 5755f441 - Add update_content method to CliveCheckerboardTableCell
- ab38e212 - Make set_evenness_styles public, remove cell classes before adding them
- 50850067 - Refactor Cart into checkerboard table
- 90a328c7 - Add content property to CliveCheckerBoardTableCell
- 9a5c87c6 - WIP UPDATE VALUES ON MOVE INSTEAD OF REBUILDING ROWS
Toggle commit list-
f283c50c - 1 commit from branch
added 1 commit
- c9f608b5 - WIP UPDATE VALUES ON MOVE INSTEAD OF REBUILDING ROWS
added 45 commits
-
139e8874...3578e9eb - 40 commits from branch
develop - 6ecb2e82 - Add support for rebuilding part of checkerboard table
- 9242e863 - Add update_content method to CliveCheckerboardTableCell
- 9f21bd7f - Make set_evenness_styles public, remove cell classes before adding them
- dcb9e643 - Refactor Cart into checkerboard table
- bf869ef6 - Add content property to CliveCheckerBoardTableCell, handle widget on update
Toggle commit list-
139e8874...3578e9eb - 40 commits from branch
