Skip to content
Snippets Groups Projects
Rishi Panthee's avatar
pushed new branch rishi556/fix-31 at hive / hive-js
Rishi Panthee's avatar
opened issue #31 "Node 22 Deprecation" at hive / hive-js
Mahdi Yari's avatar
commented on merge request !33 "Fix username validator" at hive / hive-js

Already published on npm

Mahdi Yari's avatar
opened merge request !33 "Fix username validator" at hive / hive-js
Mahdi Yari's avatar
pushed new branch fix-username-validator at hive / hive-js
mirafun mirafun's avatar
deleted branch mirafun-master-patch-74854 at hive / hive-js
Dan Notestein's avatar
accepted merge request !32 "#30 export Signature class" at hive / hive-js
Dan Notestein's avatar
pushed to branch master at hive / hive-js
Mahdi Yari's avatar
commented on merge request !32 "#30 export Signature class" at hive / hive-js

I will publish after merge. I can't merge.

Mahdi Yari's avatar
pushed to branch mirafun-master-patch-74854 at hive / hive-js
Mahdi Yari's avatar
pushed to branch mirafun-master-patch-74854 at hive / hive-js
Mahdi Yari's avatar
commented on merge request !32 "#30 export Signature class" at hive / hive-js

I didn't get notifications for your changes. Sorry.

Sergio's avatar
commented on merge request !32 "#30 export Signature class" at hive / hive-js

@mahdiyari looks good to me

Sergio's avatar
approved merge request !32 "#30 export Signature class" at hive / hive-js
mirafun mirafun's avatar
commented on merge request !32 "#30 export Signature class" at hive / hive-js

Removed the Signature class export and added signMessage function as suggested.

mirafun mirafun's avatar
pushed to branch mirafun-master-patch-74854 at hive / hive-js
Mahdi Yari's avatar
commented on merge request !32 "#30 export Signature class" at hive / hive-js

I assume the use case is signing messages. If yes, then a signMessage function might be better.

Sergio's avatar
commented on merge request !32 "#30 export Signature class" at hive / hive-js

Currently in that file we only export "utility" functions. Each one used to perform a specific task....

mirafun mirafun's avatar
opened merge request !32 "#30 export Signature class" at hive / hive-js
mirafun mirafun's avatar
pushed new branch mirafun-master-patch-74854 at hive / hive-js