#30 export Signature class

requested review from @asgarth

Currently in that file we only export "utility" functions. Each one used to perform a specific task.

I don't really like embedding the whole Signature class as that is very low level and should not be part of the top level API.

My suggestions:

1. Only implement a "sign" function that can be used externally as needed
2. Don't change hive-js at all and just import the Signature object in your code.

@mahdiyari feel free to share feedback as well.

I assume the use case is signing messages. If yes, then a signMessage function might be better.

added 1 commit

• 5c4301c8 - Add signMessage method.

Compare with previous version

Removed the Signature class export and added signMessage function as suggested.

approved this merge request

@mahdiyari looks good to me

I didn't get notifications for your changes. Sorry.

added 1 commit

• 1a782b22 - update docs - signMessage

Compare with previous version

added 1 commit

• 60f1eaca - bump v2.0.7

Compare with previous version

I will publish after merge. I can't merge.

merged

mentioned in commit bdb59cb9