Skip to content
Snippets Groups Projects

Clive integration related fixes

Merged Krzysztof Mochocki requested to merge kmochocki/clive-fixes into develop
All threads resolved!

Summary:

  • Error Handling & Logging:

    • Improved readability of error messages.
    • Made exceptions more verbose.
    • Replaced RequestError with ErrorInResponseError.
    • Added logging for CommunicationError.
  • Testing & Stability:

    • Fixed various test-related issues (e.g., startup, redundant tests, and session handling).
    • Enhanced test reliability by using proper exception detection.
    • Improved handling of timeouts and delays.
  • Settings & Configuration:

    • Refactored settings by extracting default values and environment names into separate classes.
    • Introduced is_unlocked to the wallet interface.
    • Added initialization timeout and ensured accessors for key settings.
  • Refactoring & Enhancements:

    • Introduced Overseer to validate response content separately from Communicators.
    • Improved the handling of session lifecycle and introduced a teardown mechanism.
    • Refactored AsyncHttpServer for better maintainability.
    • Extracted update_settings logic into a dedicated class.
  • Bug Fixes:

    • Fixed potential issues with session creation and closing.
    • Improved session handling in Beekeeper.
    • Fixed issues related to stderr logs and symlinks.
Edited by Krzysztof Mochocki

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mateusz Żebrak approved this merge request

    approved this merge request

  • added 39 commits

    • db5562fc...b1628f09 - 29 earlier commits
    • 7e026395 - Add logging of CommunicationError to handles
    • bcadd01d - Remove applying of session token in local beekeeper factory
    • 7da847d6 - Use proper exceptions to detect in tests
    • 41d2f527 - Fix tests that used open_wallet to close already unlocked wallet by accident
    • 9ed834e9 - Remove redundant test and fix test_api_close_session
    • ff7f981e - Fix test startup
    • 018cbe27 - Fix delay guard, to rethrow only if not UnlockIsNotAccessibleError
    • 865417c2 - Reuse new helpy errors in detectable erros in beekeepy
    • 3daeb0c4 - Improve readibility of errors by including from clause
    • b22579ae - Remove validate for wallet name and depend only on beekeeper error

    Compare with previous version

  • added 39 commits

    • b22579ae...cde377e9 - 29 earlier commits
    • 41cab498 - Add logging of CommunicationError to handles
    • 05eaa366 - Remove applying of session token in local beekeeper factory
    • 097f53e7 - Use proper exceptions to detect in tests
    • 2672eb9d - Fix tests that used open_wallet to close already unlocked wallet by accident
    • 3cd4a921 - Remove redundant test and fix test_api_close_session
    • 2229ea60 - Fix test startup
    • 087db246 - Fix delay guard, to rethrow only if not UnlockIsNotAccessibleError
    • e750acd8 - Reuse new helpy errors in detectable erros in beekeepy
    • 626851f1 - Improve readibility of errors by including from clause
    • d2c1b761 - Remove validate for wallet name and depend only on beekeeper error

    Compare with previous version

  • added 1 commit

    • 82459983 - Remove validate for wallet name and depend only on beekeeper error

    Compare with previous version

  • Mateusz Żebrak resolved all threads

    resolved all threads

  • merged

  • Please register or sign in to reply
    Loading