Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
H
HELpy
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
hive
HELpy
Commits
d4d56956
Commit
d4d56956
authored
2 months ago
by
Krzysztof Mochocki
Browse files
Options
Downloads
Patches
Plain Diff
Small refactor in _SettingsHolderBase
parent
c8d2ffc3
Branches
Branches containing commit
Tags
Tags containing commit
1 merge request
!73
Clive integration related fixes
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
helpy/helpy/_interfaces/settings_holder.py
+2
-2
2 additions, 2 deletions
helpy/helpy/_interfaces/settings_holder.py
with
2 additions
and
2 deletions
helpy/helpy/_interfaces/settings_holder.py
+
2
−
2
View file @
d4d56956
...
...
@@ -27,7 +27,7 @@ class _SettingsHolderBase(ABC, Generic[SettingsT]):
Note:
If you want to have shared settings with other instance, use `_settings`, otherwise you will pass copy.
"""
return
self
.
_
_
settings
if
self
.
__is_in_modify_settings_state
else
self
.
_get_copy_of_settings
()
return
self
.
_settings
if
self
.
__is_in_modify_settings_state
else
self
.
_get_copy_of_settings
()
@property
def
_settings
(
self
)
->
SettingsT
:
...
...
@@ -41,7 +41,7 @@ class _SettingsHolderBase(ABC, Generic[SettingsT]):
return
self
.
__settings
def
_get_copy_of_settings
(
self
)
->
SettingsT
:
return
self
.
_
_
settings
.
copy
()
return
self
.
_settings
.
copy
()
@abstractmethod
def
_get_settings_for_storage
(
self
,
settings
:
SettingsT
)
->
SettingsT
:
...
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment