Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C condenser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 44
    • Issues 44
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • hivehive
  • condenser
  • Merge requests
  • !352

Refactor the embedded player code injection logic in order to not change the initial structure

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Quoc Huy Nguyen Dinh requested to merge fix-spoilers into develop Dec 21, 2022
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

When adding a video URL in the spoiler code, the current way we inject the embedded player iframe code changes the HTML structure of the original content because it's splitting the original HTML into section and wraps each section inside a DIV. I've refactor this in order to keep the original structure intact.

Prod: https://hive.blog/hive-196233/@tarazkp/spoilers-not-included

Staging: https://staging-blog.hive.io/hive-196233/@tarazkp/spoilers-not-included

Edited Dec 21, 2022 by Quoc Huy Nguyen Dinh
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-spoilers