Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
C
condenser
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 38
    • Issues 38
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • Operations
    • Operations
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • hive
  • condenser
  • Issues
  • #112

Closed
Open
Opened Jan 15, 2021 by arcange@arcangeDeveloper

Do not use @all account for reset_xxx_list operations

When resetting lists, condenser uses the @all account as a following parameter for the custom_json operation.

https://gitlab.syncad.com/hive/condenser/-/blob/develop/src/app/components/pages/ListManagement.jsx#L486

Although the @all account has not been used for a long time, it is an (unknown) user-controlled account (not a system account) and we have no guarantees as to how this account might act in the future or how operations involving this account could be managed by apps that consider it as a standard account.

The simplest solution is to replace the referenced account with @null.

An even cleaner solution would be to not require or ignore the "following" parameter for reset operations. But that requires a change of the Hivemind code.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: hive/condenser#112