CLI - known account doesn't work in CLI

Here #238 (comment 180150) is described how known accounts works in TUI.

I think there is no need of possibility to manage known accounts list in the CLI, but it should work in the same way in case on working account, tracked/watched accounts and receivers of the operations.

Now it doesn't work like this:

1. Working and watched accounts are not known accounts

2. In CLI it should be possible to add or remove an account name to/from known accounts list.

3. Receiver of the transfer is not added to known accounts list - it is result of issue #307

@dan Please review. We are not sure about point 2, because it is impossible to use known account functionality in CLI.

mentioned in issue #291

added Priority::Medium label

changed the description

After meeting 30.09.2024

1. In CLI it should be possible to add or remove an account name to/from known accounts list.
2. The receiver of the transaction should be added to the Known accounts list.
3. If transaction is uploaded from a file, after broadcasting the receiver should be added to the Known accounts list.
4. To be decided: Now, the receiver is added to the Known accounts list when an operation is added to cart. Maybe it should be added after successfully broadcasting the transaction.

So the points 2-4 are in the issue #307.

I updated this issue and added point 1.

mentioned in merge request !552 (merged)

I checked on the branch registry.gitlab.syncad.com/hive/clive:bbd98a42.

It is possible to add and remove known accounts. If an account is added as a tracked account, it is also added as a known account.

I checked on the branch registry.gitlab.syncad.com/hive/clive:testnet-a4752f36 and registry.gitlab.syncad.com/hive/clive:a4752f36.

Todo

1. When a user:

• removes a proxy
• removes vesting routes
• removes a delegation
• removes a definition of recurrent transfer

the account shouldn't be added to the known account list.

2. Ola! Retest after merging with removing default profile feature.
   I checked and accept point works ok.

Tested: a. Transfer - from the command line and from a file.
b. Transfer from and to savings - from the command line and from a file.
c. Set a proxy - from the command line and from a file.
d. Power up - from the command line and from a file.
e. Set a vesting route - from the command line.
f. Delegate - from the command line.
g. Recurrent transfer - from command line.
h. Two operations in a file - from a file.

assigned to @wkedzierski

added Doing label

mentioned in merge request !575 (merged)

mentioned in merge request !578 (closed)

changed milestone to %Release v1.27.5.21

closed with merge request !552 (merged)

Checked on the develop.

It was partially solved: it is possible to add or remove a known account, but it is not automatically added to the known account list after performing an operation.

mentioned in merge request !600 (merged)

Checked on the release branch.

It is possible to add and remove a known account to the known accounts list. After broadcasting the transaction, the target accounts of the operations are not added to the known accounts list automatically.

Checked on the branch registry.gitlab.syncad.com/hive/clive:testnet-afc74373 (testnet).

1. Help to be improved.

See: !575 (comment 204939)

The target account is not added/added to the list of known accounts automatically after adding an operation to the cart.

2. Information about enabling or disabling the known-account feature is available with the command: clive show profile

3. The default value is enable.

4. CLI - If known-account feature is enable:

a. If you want to broadcast an operation, you must first add the target account to the list of known accounts.

It is impossible to process the following operations:

• transfer
• transfer to savings
• transfer from savings
• power-up
• delegate (add)
• withdrawal routes (set)
• set a proxy
• recurrent transfer (create, modify)

It is possible to process the following operations:

• savings - cancel transfer from savings
• power-down (start, restart, cancel)
• delegate (remove)
• withdrawal routes (remove)
• claim a new token
• vote/unvote for witness(es)
• vote/unvote for proposal(s)
• clear a proxy
• recurrent transfer (remove)
• update authority (posting, active, memo)

b. If the target account is not on the known account list, it is not possible to prepare the transaction using --no-broadcast.

c. If the target account is not on the known account list, it is not possible to save transaction to the file.

d. If the target account is not on the known account list, it is not possible to broadcast the transaction from a file.

5. TUI - If known-account feature is enable:
   a. TUI - The target account is added to the list of known accounts automatically after adding an operation to the cart.

The target account is automatically added to the list of known accounts after adding to the cart one of the following operations:

• transfer
• transfer to savings
• transfer from savings
• power-up
• delegate
• withdrawal routes
• set a proxy

The target account is not automatically added to the list of known accounts after adding to the cart one of the following operations:

• savings - cancel transfer from savings
• power-down
• delegate (remove)
• withdrawal routes (remove)
• vote/unvote for witness(es)
• vote/unvote for proposal(s)
• clear a proxy

b. The information about known/unknown account is shown.

c. If the transaction is loaded from a file, the target account should be added to the list of known accounts. Currently, this doesn't work.

!575 (comment 204946)

6. CLI - If known-account feature is disable:

a. CLI - The target account is not checked if it is on the list of known accounts.

The following operations can be broadcast even if the target account is not on the list of known accounts:

• transfer
• transfer to savings
• transfer from savings
• power-up
• delegate
• withdrawal routes
• set a proxy
• recurrent transfer

b. If the target account is not on the known account list, it is possible to prepare the transaction using --no-broadcast.

c. If the target account is not on the known account list, it is possible to save transaction to the file.

d. If the target account is not on the known account list, it is possible to broadcast the transaction from a file.

7. TUI - If known-account feature is disable:
   a. TUI - The target account is not added to the list of known accounts automatically after adding an operation to the cart.

The target account is not automatically added to the list of known accounts after adding to the cart one of the following operations:

• transfer
• transfer to savings
• transfer from savings
• power-up
• delegate
• withdrawal routes
• set a proxy.

b. The information about known/unknown account is shown.

8. Regardless of whether the known-account feature is enabled or disabled, the user can always add/remove an account the list of known accounts manually in TUI and CLI.