Delrifai/#394 add charts to balance history
--Added chart to the main account page. The limit on this chart is 100 and hence returns the latest 100 results of the mont. I have removed the old link beside the wallet for the details
-- Added to the chart to Balance History Page: This chart gets results of 5000 and shows them, however, this needs to be updated later. Currently, I am showing changes/day, if we update this in the API so that it gives us the balance of the day and change in the balance per day, the chart will be more readable and have high performance. We also need the API to filter by the operation type so we can display relevant data for it.
-- Updated the Operations table to show vests properly as there was a bug there, and also added highlight for expanded row
Merge request reports
Activity
requested review from @mcfarhat
assigned to @mcfarhat
added 31 commits
-
40dac52f...c2dacbc9 - 25 commits from branch
develop
- a44fa866 - Issue 394- Fix issue of vest formatting
- 0e384939 - Issue 394 - Create the logic for balance history charts
- 297e0285 - Issue #394 (closed) - Remove Balance History Link
- 2cde49d7 - Issue #394 (closed) - Remove Balance History Link
- c6953e69 - Fixing issues after testing
- f1687ba3 - Fixes and Performance optimizations
Toggle commit list-
40dac52f...c2dacbc9 - 25 commits from branch
- Resolved by Dima Rifai
Thanks for this, looks great! Few improvements needed:
- In the user profile display, change the word "Details" to "Full Chart". Remove tooltip. Also move it inside the view, place it to the top left right above chart, and make it a button.
- Checking the actifit user profile page, i noticed switching to VESTS view would show multiple data points for same day, unlike HIVE/HBD. Is this intended? (notice 5 points for the days). It would be optimal if we show one per day, like the others.
-
In the chart details page, the right side of the zoom filter is cut off (notice only Dec is showing without the day)
-
In the chart display page, filtering by a larger date range for HIVE does not seem to load data up to the actual range . See for example account for pjansen below. 30 days is only showing starting Dec 10.
added To Do label
added 8 commits
- b60681da - Issue 394- Fix issue of vest formatting
- 20186026 - Issue 394 - Create the logic for balance history charts
- e4d5946d - Issue #394 (closed) - Remove Balance History Link
- db53fa39 - Issue #394 (closed) - Remove Balance History Link
- 8f9fb17d - Fixing issues after testing
- 40dac52f - Fixes and Performance optimizations
- 65fe8594 - Merge Develop into Branch
- cd1f66a1 - Fix Review Notes
Toggle commit listThanks, looking much better!
Couple of additional issues:
-
In particular for blocktrades account, noticed the vests option displays not the most recent data (showing Dec 1-5), if we have constraints on amount of data, probably best to return the newest data
-
On the user page, no data is shown under VESTS option (probably related to issue above)
-
added 2 commits
closing in favor of !507 (merged) as confirmed by @delrifai