Add tests for update_proposal_opetation

python/tests/base_api/test_update_proposal_operation.py

+from __future__ import annotations
+
+import json
+from typing import TYPE_CHECKING, Final
+
+import pytest
+from google.protobuf.json_format import MessageToDict
+
+from wax._private.exceptions import WaxError
+from wax.proto.update_proposal_pb2 import update_proposal, update_proposal_end_date, update_proposal_extension
+
+if TYPE_CHECKING:
+    from wax.interfaces import ITransaction, IWaxBaseInterface
+
+
+@pytest.mark.describe("Should initialize update proposal with mandatory fields only")
+def test_initialize_update_proposal_with_mandatory_fields(transaction: ITransaction) -> None:
+    transaction.push_operation(
+        operation=update_proposal(
+            proposal_id=123,
+            creator="alice",
+            daily_pay={"amount": "1000", "precision": 3, "nai": "@@000000013"},
+            subject="Improve UI Design",
+            permlink="improve-ui",
+        )
+    )
+
+    expected: Final[dict] = {
+        "type": "update_proposal_operation",
+        "value": {
+            "creator": "alice",
+            "daily_pay": {"amount": "1000", "nai": "@@000000013", "precision": 3},
+            "permlink": "improve-ui",
+            "proposal_id": "123",
+            "subject": "Improve UI Design",
+        },
+    }
+
+    assert json.loads(transaction.to_api())["operations"][0] == expected
+
+
+@pytest.mark.skip(reason="python version `update_proposal` not implemented")
+@pytest.mark.describe("Should add end_date in update proposal when provided")
+def test_adds_end_date_to_update_proposal_when_provided(transaction: ITransaction) -> None:
+    transaction.push_operation(
+        operation=update_proposal(
+            proposal_id=123,
+            creator="alice",
+            daily_pay={"amount": "1000", "precision": 3, "nai": "@@000000013"},
+            subject="Improve UI Design",
+            permlink="improve-ui",
+            extensions=[
+                update_proposal_extension(update_proposal_end_date=update_proposal_end_date(end_date="2023-03-14"))
+            ],
+        )
+    )
+
+    expected: Final[dict] = {
+        "type": "update_proposal_operation",
+        "value": {
+            "creator": "alice",
+            "daily_pay": {"amount": "1000", "nai": "@@000000013", "precision": 3},
+            "extensions": [{"type": "update_proposal_end_date", "value": {"end_date": "2023-03-14T00:00:00"}}],
+            "permlink": "improve-ui",
+            "proposal_id": "123",
+            "subject": "Improve UI Design",
+        },
+    }
+
+    # TODO: fix in wax problem with converting time to specyfic type
+    #  E - 'value': {'end_date': '2023-03-14T00:00:00'}}],
+    #  E         ?                          ---------
+    #  E + 'value': {'end_date': '2023-03-14'}}],
+    assert json.loads(transaction.to_api())["operations"][0] == expected
+
+
+@pytest.mark.skip(reason="python version `update_proposal` not implemented")
+@pytest.mark.describe("Should handle edge case in update proposal where end_date is given as timestamp")
+def test_handles_update_proposal_with_timestamp_end_date(transaction: ITransaction) -> None:
+    transaction.push_operation(
+        operation=update_proposal(
+            proposal_id=123,
+            creator="alice",
+            daily_pay={"amount": "1000", "precision": 3, "nai": "@@000000013"},
+            subject="Improve UI Design",
+            permlink="improve-ui",
+            extensions=[
+                # TODO: TypeError: bad argument type for built-in operation
+                #  in TS test end_date is provided as int                                             ↓ ↓ ↓ ↓ ↓ ↓ ↓
+                update_proposal_extension(update_proposal_end_date=update_proposal_end_date(end_date="1678917600000"))
+            ],
+        )
+    )
+
+    expected: Final[dict] = {
+        "type": "update_proposal_operation",
+        "value": {
+            "creator": "alice",
+            "daily_pay": {"amount": "1000", "nai": "@@000000013", "precision": 3},
+            "extensions": [{"type": "update_proposal_end_date", "value": {"end_date": "2023-03-15T22:00:00"}}],
+            "permlink": "improve-ui",
+            "proposal_id": "123",
+            "subject": "Improve UI Design",
+        },
+    }
+
+    # TODO: fix in wax problem with converting time to specyfic type
+    #  E - 'pattern_value': {'end_date': '2023-03-15T22:00:00'}}],
+    #  E ?                      -------- ^ ^ ^ ^ ^ ^
+    #  E + 'wax_value':     {'end_date': '1678917600000'}}],
+    #  problems:
+    #  - update_proposal_end_date accept date only in string format
+    #  - wax not converted "1678917600000" into date model
+    #  - TypeError: bad argument type for built-in operation
+    assert json.loads(transaction.to_api())["operations"][0] == expected
+
+
+@pytest.mark.skip(reason="can't convert wax operation to legacy format, missing method `tx.toLegacyApi()")
+@pytest.mark.describe("Should be able to convert transaction to legacy api with end_date property")
+def test_convert_update_proposal_to_legacy_api_with_end_date(transaction: ITransaction) -> None:
+    transaction.push_operation(
+        operation=update_proposal(
+            proposal_id=123,
+            creator="alice",
+            daily_pay={"amount": "1000", "precision": 3, "nai": "@@000000013"},
+            subject="Improve UI Design",
+            permlink="improve-ui",
+            extensions=[
+                update_proposal_extension(update_proposal_end_date=update_proposal_end_date(end_date="2023-03-14"))
+            ],
+        )
+    )
+
+    expected_in_legacy_format: Final[list] = [
+        "update_proposal",
+        {
+            "creator": "alice",
+            "daily_pay": "1.000 HBD",
+            "extensions": [[1, {"end_date": "2023-03-14T00:00:00"}]],
+            "permlink": "improve-ui",
+            "proposal_id": 123,
+            "subject": "Improve UI Design",
+        },
+    ]
+
+    assert [
+        MessageToDict(op, including_default_value_fields=True) for op in transaction.transaction.operations
+    ] == expected_in_legacy_format
+
+
+@pytest.mark.skip(reason="python version `update_proposal` not implemented")
+@pytest.mark.describe("Should fail when invalid asset is provided")
+def test_reject_invalid_asset_in_update_proposal_operation(wax: IWaxBaseInterface, transaction: ITransaction) -> None:
+    # TODO: shouldn't by possible to create update_proposal object with wrong type of asset in daily_pay field
+    with pytest.raises(WaxError) as error:
+        transaction.push_operation(
+            update_proposal(
+                proposal_id=100,
+                creator="initminer",
+                daily_pay=wax.hive.satoshis(0),  # proposals daily pay should be give in HBD
+                subject="subject",
+                permlink="permlink",
+                extensions=[],
+            )
+        )
+
+    expected_message = (
+        "Invalid asset provided: "
+        + json.dumps({"amount": "0", "precision": 3, "nai": "@@000000021"})
+        + '. Expected asset symbol(s): "@@000000013" (HBD) with precision: 3".'
+    )
+
+    assert expected_message in str(error.value.args)
+
+
+@pytest.mark.describe(
+    "Should be able to create an update proposal with underlying extensions using transaction interface"
+)
+def test_transaction_interface_handles_update_proposal_with_extensions(
+    wax: IWaxBaseInterface, transaction: ITransaction
+) -> None:
+    transaction.push_operation(
+        update_proposal(
+            proposal_id=100,
+            creator="initminer",
+            daily_pay=wax.hbd.satoshis(0),
+            subject="subject",
+            permlink="permlink",
+            extensions=[
+                update_proposal_extension(
+                    update_proposal_end_date=update_proposal_end_date(end_date="2023-08-01T15:38:48")
+                )
+            ],
+        )
+    )
+
+    transaction.push_operation(
+        update_proposal(
+            proposal_id=100,
+            creator="initminer",
+            daily_pay=wax.hbd.satoshis(0),
+            subject="subject",
+            permlink="permlink",
+            extensions=[],
+        )
+    )
+
+    expected: Final[list] = [
+        {
+            "update_proposal": {
+                "creator": "initminer",
+                "daily_pay": {"amount": "0", "nai": "@@000000013", "precision": 3},
+                "permlink": "permlink",
+                "subject": "subject",
+                "proposal_id": "100",
+                "extensions": [{"update_proposal_end_date": {"end_date": "2023-08-01T15:38:48"}}],
+            }
+        },
+        {
+            "update_proposal": {
+                "creator": "initminer",
+                "daily_pay": {"amount": "0", "nai": "@@000000013", "precision": 3},
+                "permlink": "permlink",
+                "subject": "subject",
+                "proposal_id": "100",
+                "extensions": [],
+            }
+        },
+    ]
+
+    # TODO: repair this assert when transaction.from_proto_to_dict() will be available
+    assert [
+        MessageToDict(op, including_default_value_fields=True) for op in transaction.transaction.operations
+    ] == expected