Patterns corrected for condenser/follow/tags_api groups (both old and tavern)

Corrections include:

• rebranding
• accepted different future cashout_time (prior to HF17 it was taken from root and we don't want to introduce hardfork differences to HiveMind)
• accepted different post_id
• accepted lack of double-escaped slashes in json_metadata (now is better)
• corrected indent for tavern's 2 spaces
• corrected cases of CLRF

Comparison script now removes .diff.json and .out.json files from previous run. It also generates .out.json with error message in case of error/no response (in other words all failing tests have .out.json file).

Added comments to failing tests why they are failing and to tests with empty results why there is no other option.

Some tests were marked as passing - that is valid for hivemind!61 (merged)

Just out of curiosity, is this just some default value for things that don't have a valid cashout time? I'm asking because 1990 was before blockchain started.

At times value displayed as cashout_time is taken from hive_posts.payout_at field and its default value is 1990-01-01 for some reason (tbh. I only spotted it is indeed strange when you pointed that out - shouldn't it rather be 1970-01-01 like in other fields where date is stored?)

I spoke to @jsalyers just now, and he confirms that hivemind does default to 1990 instead of 1970 (but he doesn't know why).

Apparently it's defined that way in schema file, but still no idea why. Anyways, it looks fine, so going to merge this in.

approved this merge request

merged

mentioned in commit 886dc5c0