Merge branch 'condenser_get_discussions_by_comments' into 'master'

condenser_api tests get_discussions_by_comments moved to folder

See merge request !81

hivemind/tavern/condenser_api_negative/get_discussions_by_comments/unexpected_keyword.tavern.yaml

+---
+  test_name: Hivemind condenser_api.get_discussions_by_comments unexpected keyword patterns test
+
+  marks:
+    - patterntest
+    - negative
+    - failing
+    - xfail # while this would be acceptable we should change it to invalid parameters over server error (code suggests we wanted to completely silence that, but rest passes is as generic error, old code was the same so...)
+
+  includes:
+    - !include ../../common.yaml
+
+  stages:
+    - name: get_replies_by_last_update unexpected keyword 
+      request:
+        url: "{service.proto:s}://{service.server:s}:{service.port}/"
+        method: POST
+        headers:
+          content-type: application/json
+        json:
+          jsonrpc: "2.0"
+          id: 1
+          method: "condenser_api.get_discussions_by_comments"
+          params: [{"author": "steemit"}]
+      response:
+        status_code: 200
+        verify_response_with:
+          function: validate_response:compare_response_with_pattern
+          extra_kwargs:
+            method: "unexpected_keyword"
+            directory: "condenser_api_negative/get_discussions_by_comments"
+            error_response: true
\ No newline at end of file

hivemind/tavern/condenser_api_patterns/get_discussions_by_comments/admin.tavern.yaml

+---
+  test_name: Hivemind condenser_api.get_discussions_by_comments patterns test
+
+  marks:
+    - patterntest
+
+  includes:
+    - !include ../../common.yaml
+
+  stages:
+    - name: get_discussions_by_comments
+      request:
+        url: "{service.proto:s}://{service.server:s}:{service.port}/"
+        method: POST
+        headers:
+          content-type: application/json
+        json:
+          jsonrpc: "2.0"
+          id: 1
+          method: "condenser_api.get_discussions_by_comments"
+          params: {"start_author":"admin","start_permlink":"firstpost","limit":1}
+      response:
+        status_code: 200
+        verify_response_with:
+          function: validate_response:compare_response_with_pattern
+          extra_kwargs:
+            method: "admin"
+            directory: "condenser_api_patterns/get_discussions_by_comments"
\ No newline at end of file

hivemind/tavern/test_condenser_api_patterns.tavern.yaml

----
-  test_name: Hivemind condenser_api.get_discussions_by_comments patterns test
-
-  marks:
-    - patterntest
-
-  includes:
-    - !include common.yaml
-
-  stages:
-    - name: get_discussions_by_comments
-      request:
-        url: "{service.proto:s}://{service.server:s}:{service.port}/"
-        method: POST
-        headers:
-          content-type: application/json
-        json:
-          jsonrpc: "2.0"
-          id: 1
-          method: "condenser_api.get_discussions_by_comments"
-          params: {"start_author":"admin","start_permlink":"firstpost","limit":1}
-      response:
-        status_code: 200
-        verify_response_with:
-          function: validate_response:compare_response_with_pattern
-          extra_kwargs:
-            method: "get_discussions_by_comments"
-            directory: "condenser_api_patterns"
-
----
-  test_name: Hivemind condenser_api.get_discussions_by_comments unexpected keyword patterns test
-
-  marks:
-    - patterntest
-    - failing
-    - xfail # while this would be acceptable we should change it to invalid parameters over server error (code suggests we wanted to completely silence that, but rest passes is as generic error, old code was the same so...)
-
-  includes:
-    - !include common.yaml
-
-  stages:
-    - name: get_replies_by_last_update unexpected keyword 
-      request:
-        url: "{service.proto:s}://{service.server:s}:{service.port}/"
-        method: POST
-        headers:
-          content-type: application/json
-        json:
-          jsonrpc: "2.0"
-          id: 1
-          method: "condenser_api.get_discussions_by_comments"
-          params: [{"author": "steemit"}]
-      response:
-        status_code: 200
-        verify_response_with:
-          function: validate_response:compare_response_with_pattern
-          extra_kwargs:
-            method: "get_discussions_by_comments_unexpected_keyword"
-            directory: "condenser_api_patterns"
-            error_response: true
-
 ---
   test_name: Hivemind condenser_api.get_replies_by_last_update patterns test