Skip to content
Snippets Groups Projects

list_comments api call improvements

Merged Dariusz Kędzierski requested to merge dk-list-comments-by-fixes into develop
All threads resolved!
  • Improved sql for list_comments
  • Removed materialized view from schema: it was not used, it required expensive refreshes
  • Some calls are slow comparing to original hived calls
  • by_cashout, by_update and by_author_update results are different than expected (waiting for merge from #47 (closed))
  • fixed manual tests for list_comments
  • Posting a comment will now update active but active is not propagating up at the moment,
  • Added post object for database api post
  • Added a possibility to convert amount notation to nai notation
  • Other minor fixes
Edited by Dariusz Kędzierski

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 43 commits

    • 2fba430f...eec369bd - 42 commits from branch develop
    • 1db19968 - Merge branch 'dk-list-comments-by-fixes' of gitlab.syncad.com:hive/hivemind...

    Compare with previous version

  • reopened

  • Dariusz Kędzierski marked as a Work In Progress

    marked as a Work In Progress

  • Dariusz Kędzierski changed the description

    changed the description

  • Still WIP: debugging differences in date fields

  • added 20 commits

    • 2e683c1f...574cdd05 - 19 commits from branch develop
    • 47b137c4 - Merge branch 'dk-list-comments-by-fixes' of gitlab.syncad.com:hive/hivemind...

    Compare with previous version

  • Dariusz Kędzierski unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Dariusz Kędzierski changed the description

    changed the description

  • I have some minor? problem with sorting in by_permlink. Consider example, earlier we had this issue solved by materialized view (but now its removed).

    dariusz-work@asgard:/mnt/storage-hdd-2/Sources/hivemind/tests/manual_tests(dk-list-comments-by-fixes [+*])$ python3 list_comments_by_permlink.py 
    Querying reference node
    +-----------------+-------------------------------------------------------------------------------------------------------------------------------+
    |      author     |                                                            permlink                                                           |
    +-----------------+-------------------------------------------------------------------------------------------------------------------------------+
    |     steemit     |                                                           firstpost                                                           |
    | steemit-awesome |                                                    show-me-some-love-please                                                   |
    | steemit-awesome |                                                        what-is-steemit                                                        |
    |   steemit-com   |                re-grimjo33-tangkuban-perahu-another-beautiful-indonesia-tourism-destination-20160801t200152355z               |
    |   steemit-com   |    re-riensen-steemit-etiquette-using-95-bot-accounts-to-upvote-your-own-content-fair-game-or-not-cool-20160801t200656898z    |
    |    steemit-de   |                                             dns-via-steem-deutsche-version-deutsch                                            |
    |    steemit-de   |                         re-rittr-re-steemit-germany-dns-via-steem-deutsche-version-20160809t100526949z                        |
    | steemit-germany |                                                 dns-via-steem-deutsche-version                                                |
    | steemit-germany |                         re-rittr-re-steemit-germany-dns-via-steem-deutsche-version-20160809t093806686z                        |
    |   steemit-inga  | i-was-born-in-latvia-small-country-by-the-baltic-sea-my-glass-is-always-half-full-sometimes-it-has-kambucha-sometimes-tequila |
    +-----------------+-------------------------------------------------------------------------------------------------------------------------------+
    Querying test node
    +-----------------+---------------------------------------------------------------------------------------------------------------------------------------+
    |      author     |                                                                permlink                                                               |
    +-----------------+---------------------------------------------------------------------------------------------------------------------------------------+
    |     steemit     |                                                               firstpost                                                               |
    | steemit-awesome |                                                        show-me-some-love-please                                                       |
    | steemit-awesome |                                                            what-is-steemit                                                            |
    |   steemit-com   |                    re-grimjo33-tangkuban-perahu-another-beautiful-indonesia-tourism-destination-20160801t200152355z                   |
    |   steemit-com   |        re-riensen-steemit-etiquette-using-95-bot-accounts-to-upvote-your-own-content-fair-game-or-not-cool-20160801t200656898z        |
    |    steemit-de   |                             re-rittr-re-steemit-germany-dns-via-steem-deutsche-version-20160809t100526949z                            |
    | steemit-germany |                             re-rittr-re-steemit-germany-dns-via-steem-deutsche-version-20160809t093806686z                            |
    |   steemit-inga  |     i-was-born-in-latvia-small-country-by-the-baltic-sea-my-glass-is-always-half-full-sometimes-it-has-kambucha-sometimes-tequila     |
    |   steemit-inga  |               my-name-is-inga-and-steemers-please-multiply-community-healing-power-and-help-this-amazing-little-fighter               |
    |   steemit-inga  | re-mranderson-steemaway-vote-and-receive-original-fine-art-worth-thousands-of-dollars-delivered-free-to-your-door-20160802t045448558z |
    +-----------------+---------------------------------------------------------------------------------------------------------------------------------------+
    
  • added 1 commit

    • b0f42d83 - Reverted some active flag changes

    Compare with previous version

  • Bartek Wrona
  • added 1 commit

    • d1e5ec91 - list_comments_by moved to sql

    Compare with previous version

  • added 6 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • list_comments queries moved to database side

  • Bartek Wrona resolved all threads

    resolved all threads

  • merged

  • Bartek Wrona mentioned in commit a1f4d0b2

    mentioned in commit a1f4d0b2

  • Please register or sign in to reply
    Loading