list_comments api call improvements
All threads resolved!
All threads resolved!
- Improved sql for list_comments
- Removed materialized view from schema: it was not used, it required expensive refreshes
- Some calls are slow comparing to original hived calls
- by_cashout, by_update and by_author_update results are different than expected (waiting for merge from #47 (closed))
- fixed manual tests for list_comments
- Posting a comment will now update active but active is not propagating up at the moment,
- Added post object for database api post
- Added a possibility to convert amount notation to nai notation
- Other minor fixes
Edited by Dariusz Kędzierski
Merge request reports
Activity
added 43 commits
-
2fba430f...eec369bd - 42 commits from branch
develop
- 1db19968 - Merge branch 'dk-list-comments-by-fixes' of gitlab.syncad.com:hive/hivemind...
-
2fba430f...eec369bd - 42 commits from branch
added 20 commits
-
2e683c1f...574cdd05 - 19 commits from branch
develop
- 47b137c4 - Merge branch 'dk-list-comments-by-fixes' of gitlab.syncad.com:hive/hivemind...
-
2e683c1f...574cdd05 - 19 commits from branch
I have some minor? problem with sorting in
by_permlink
. Consider example, earlier we had this issue solved by materialized view (but now its removed).dariusz-work@asgard:/mnt/storage-hdd-2/Sources/hivemind/tests/manual_tests(dk-list-comments-by-fixes [+*])$ python3 list_comments_by_permlink.py Querying reference node +-----------------+-------------------------------------------------------------------------------------------------------------------------------+ | author | permlink | +-----------------+-------------------------------------------------------------------------------------------------------------------------------+ | steemit | firstpost | | steemit-awesome | show-me-some-love-please | | steemit-awesome | what-is-steemit | | steemit-com | re-grimjo33-tangkuban-perahu-another-beautiful-indonesia-tourism-destination-20160801t200152355z | | steemit-com | re-riensen-steemit-etiquette-using-95-bot-accounts-to-upvote-your-own-content-fair-game-or-not-cool-20160801t200656898z | | steemit-de | dns-via-steem-deutsche-version-deutsch | | steemit-de | re-rittr-re-steemit-germany-dns-via-steem-deutsche-version-20160809t100526949z | | steemit-germany | dns-via-steem-deutsche-version | | steemit-germany | re-rittr-re-steemit-germany-dns-via-steem-deutsche-version-20160809t093806686z | | steemit-inga | i-was-born-in-latvia-small-country-by-the-baltic-sea-my-glass-is-always-half-full-sometimes-it-has-kambucha-sometimes-tequila | +-----------------+-------------------------------------------------------------------------------------------------------------------------------+ Querying test node +-----------------+---------------------------------------------------------------------------------------------------------------------------------------+ | author | permlink | +-----------------+---------------------------------------------------------------------------------------------------------------------------------------+ | steemit | firstpost | | steemit-awesome | show-me-some-love-please | | steemit-awesome | what-is-steemit | | steemit-com | re-grimjo33-tangkuban-perahu-another-beautiful-indonesia-tourism-destination-20160801t200152355z | | steemit-com | re-riensen-steemit-etiquette-using-95-bot-accounts-to-upvote-your-own-content-fair-game-or-not-cool-20160801t200656898z | | steemit-de | re-rittr-re-steemit-germany-dns-via-steem-deutsche-version-20160809t100526949z | | steemit-germany | re-rittr-re-steemit-germany-dns-via-steem-deutsche-version-20160809t093806686z | | steemit-inga | i-was-born-in-latvia-small-country-by-the-baltic-sea-my-glass-is-always-half-full-sometimes-it-has-kambucha-sometimes-tequila | | steemit-inga | my-name-is-inga-and-steemers-please-multiply-community-healing-power-and-help-this-amazing-little-fighter | | steemit-inga | re-mranderson-steemaway-vote-and-receive-original-fine-art-worth-thousands-of-dollars-delivered-free-to-your-door-20160802t045448558z | +-----------------+---------------------------------------------------------------------------------------------------------------------------------------+
- Resolved by Bartek Wrona
added 6 commits
-
d1e5ec91...8c232309 - 5 commits from branch
develop
- d08a7f82 - Rebase merge
-
d1e5ec91...8c232309 - 5 commits from branch
mentioned in commit a1f4d0b2
Please register or sign in to reply