Community type 2 and 3 + update community type op

feature set

This feature enables the new community types as defined in the original doc:

• type 1: Topic: anyone can post or comment
• type 2: Journal: guests can comment but not post. only members can post.
• type 3: Council: only members can post or comment

test cases

for all tests, the account ismember will be a member of all the communities and notmember won't be.

• create a community type 1 hive-111119
• create a community type 2 hive-211119
• create a community type 3 hive-311119
• Community type 1 tests
• • post in community type 1 from member => not muted
• • post in community type 1 from non member => not muted
• • comment in community type 1 from member => not muted
• • comment in community type 1 from non member => not muted
• • comment in community type 1 from member at depth 2 => not muted
• Community type 2 tests
• • post in community type 2 from member => not muted
• • post in community type 2 from non member => muted
• • comment in community type 2 from member => not muted
• • comment in community type 2 from non member => not muted
• • comment in community type 2 from member at depth 2 => not muted
• Community type 3 tests
• • post in community type 3 from member => not muted
• • post in community type 3 from non member => muted
• • comment in community type 3 from member => not muted
• • comment in community type 3 from non member => muted
• • comment in community type 3 from member at depth 2 => not muted
• Change community type 1 to community type 3
• • change ismember to a mod (to validate that rules apply to roles above member and not just to member)
• • post in community type 3 from member => not muted
• • post in community type 3 from non member => muted
• • comment in community type 3 from member => not muted
• • comment in community type 3 from non member => muted

hive/indexer/community.py

@@ -221,25 +221,19 @@ class Community:
 
         For a comment to be valid, these conditions apply:
             - Author is not muted in this community
-            - For council post/comment, author must be a member
-            - For journal post, author must be a member
             - Community must exist
+
+        Note that the checks related to community types are performed on insert
+        via the sql function process_community_post
         """
 
         assert community_id, 'no community_id'
-        community = cls._get_name(community_id)
         account_id = Accounts.get_id(comment_op['author'])
         role = cls.get_user_role(community_id, account_id)
-        type_id = int(community[5])
 
         # TODO: check `nsfw` tag requirement #267
         # TODO: (1.5) check that beneficiaries are valid
 
-        if type_id == TYPE_JOURNAL:
-            if not comment_op['parent_author']:
-                return role >= Role.member
-        elif type_id == TYPE_COUNCIL:
-            return role >= Role.member
         return role >= Role.guest  # or at least not muted