Community type 2 and 3 + update community type op

feature set

This feature enables the new community types as defined in the original doc:

• type 1: Topic: anyone can post or comment
• type 2: Journal: guests can comment but not post. only members can post.
• type 3: Council: only members can post or comment

test cases

for all tests, the account ismember will be a member of all the communities and notmember won't be.

• create a community type 1 hive-111119
• create a community type 2 hive-211119
• create a community type 3 hive-311119
• Community type 1 tests
• • post in community type 1 from member => not muted
• • post in community type 1 from non member => not muted
• • comment in community type 1 from member => not muted
• • comment in community type 1 from non member => not muted
• • comment in community type 1 from member at depth 2 => not muted
• Community type 2 tests
• • post in community type 2 from member => not muted
• • post in community type 2 from non member => muted
• • comment in community type 2 from member => not muted
• • comment in community type 2 from non member => not muted
• • comment in community type 2 from member at depth 2 => not muted
• Community type 3 tests
• • post in community type 3 from member => not muted
• • post in community type 3 from non member => muted
• • comment in community type 3 from member => not muted
• • comment in community type 3 from non member => muted
• • comment in community type 3 from member at depth 2 => not muted
• Change community type 1 to community type 3
• • change ismember to a mod (to validate that rules apply to roles above member and not just to member)
• • post in community type 3 from member => not muted
• • post in community type 3 from non member => muted
• • comment in community type 3 from member => not muted
• • comment in community type 3 from non member => muted

hive/indexer/community.py

@@ -105,7 +105,7 @@ def read_key_dict(obj, key):
     return obj[key]
 
 def read_key_integer(op, key):
-    """Reads a key from dict, ensuring valid bool if present."""
+    """Reads a key from dict, ensuring valid integer if present."""
     if key in op:
         assert isinstance(op[key], int), 'must be int: %s' % key
         return op[key]
@@ -234,7 +234,7 @@ class Community:
         # TODO: check `nsfw` tag requirement #267
         # TODO: (1.5) check that beneficiaries are valid
 
-        return role >= Role.guest  # or at least not muted
+        return role >= Role.guest  # At least not muted
 
 
 class CommunityOp: