Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
H
hivemind
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
hive
hivemind
Merge requests
!370
Jsalyers muting at sql level
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Jsalyers muting at sql level
jsalyers-muting-at-sql-level
into
develop
Overview
9
Commits
92
Pipelines
0
Changes
1
Merged
Jason Salyers
requested to merge
jsalyers-muting-at-sql-level
into
develop
4 years ago
Overview
6
Commits
92
Pipelines
0
Changes
1
Expand
0
0
Merge request reports
Viewing commit
5467b448
Prev
Next
Show latest version
1 file
+
7
−
10
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
5467b448
Follower and following entries must be strings. Same behaviour as in old hivemind
· 5467b448
Dariusz Kędzierski
authored
4 years ago
hive/indexer/follow.py
+
7
−
10
Options
@@ -104,18 +104,15 @@ class Follow(DbAdapterHolder):
op
[
'
following
'
]
=
op
[
'
following
'
]
if
isinstance
(
op
[
'
following
'
],
list
)
else
[
op
[
'
following
'
]]
# additional layer of protection against putting complex data types as user names
as_str
=
[]
# we expecting follower and following entries to be strings
# in older hivemind this check was done in Accounts.exists
# now following can be list of names so we need to check if all entries are strings
for
following
in
op
[
'
following
'
]:
if
isinstance
(
following
,
list
)
or
isinstance
(
following
,
dict
):
as_str
.
append
(
dumps
(
following
))
else
:
as_str
.
append
(
str
(
following
))
op
[
'
following
'
]
=
as_str
if
not
isinstance
(
following
,
str
):
return
None
if
isinstance
(
op
[
'
follower
'
],
list
)
or
isinstance
(
op
[
'
follower
'
],
dict
):
op
[
'
follower
'
]
=
dumps
(
op
[
'
follower
'
])
else
:
op
[
'
follower
'
]
=
str
(
op
[
'
follower
'
])
if
not
isinstance
(
op
[
'
follower
'
],
str
):
return
None
# follower/following is empty
if
not
op
[
'
follower
'
]
or
not
op
[
'
following
'
]:
Loading