Follower and following names validation and type check (!364) · Merge requests · hive / hivemind · GitLab

Snippets Groups Projects

Merged Dariusz Kędzierski requested to merge dk-strict-follow-name-check into develop 4 years ago

Mimic original behaviour:

if following name does not exist do not process it: basically equal to drop op for single following entry
if follower name does not exist drop op
Mock data with different complex types combinations as names

Edited 4 years ago by Dariusz Kędzierski

Activity

Dariusz Kędzierski added 1 commit 4 years ago
added 1 commit

09d5c94c - Follower and following entries must be strings. Same behaviour as in old hivemind

Compare with previous version
Bartek Wrona @wrona 4 years ago

Owner

Resolved 4 years ago by Dariusz Kędzierski

Does not match original behavior where follower attribute value has been interprated as string or operation has been rejected as is. See reference place where check has been done: https://gitlab.syncad.com/hive/hivemind/-/blob/master/hive/indexer/follow.py#L103 and definition of called 'Account.exist' method: https://gitlab.syncad.com/hive/hivemind/-/blob/master/hive/indexer/accounts.py#L68 There shall be also added tests to explicitly show follow changes on some testing account, when ops were accepted or not.

Last reply by Dariusz Kędzierski 4 years ago
Bartek Wrona added To Do label 4 years ago

added To Do label
Dariusz Kędzierski added 1 commit 4 years ago
added 1 commit

6c22a3c4 - Mimic old hivemind behaviour for follower, following check. Use get_follow_count for testing

Compare with previous version
Bartek Wrona @wrona 4 years ago

Owner

Probably you missed to add new commit of tests/tests_api submodule or existing tests are completely ignoring changes done above.
Dariusz Kędzierski added 1 commit 4 years ago
added 1 commit

d376dabf - Hardcode 5000017 for max block to actually sync mocked data

Compare with previous version
Dariusz Kędzierski added 1 commit 4 years ago
added 1 commit

dbef3168 - Revert exists method to its original form. List check is not needed there

Compare with previous version
Dariusz Kędzierski added 1 commit 4 years ago
added 1 commit

f2a0f4a4 - Guard escape_characters with assert

Compare with previous version
Dariusz Kędzierski changed title from Cast all follow name data to string to Follower and following names validation and type check 4 years ago

changed title from Cast all follow name data to string to Follower and following names validation and type check
Dariusz Kędzierski changed the description 4 years ago

changed the description
Dariusz Kędzierski resolved all threads 4 years ago

resolved all threads
Dariusz Kędzierski added 1 commit 4 years ago
added 1 commit

97e50698 - Extend mock file with JS test

Compare with previous version
Dariusz Kędzierski added 11 commits 4 years ago
added 11 commits

97e50698...8d06d8bc - 10 commits from branch develop

51882997 - Rebase to current develop

Compare with previous version
Bartek Wrona @wrona started a thread on the diff 4 years ago

Resolved 4 years ago by Bartek Wrona
Last reply by Bartek Wrona 4 years ago

Bartek Wrona @wrona started a thread on an old version of the diff 4 years ago

Resolved 4 years ago by Dariusz Kędzierski

Dariusz Kędzierski added 1 commit 4 years ago

added 1 commit

31e5c984 - Removed delta calculations from follow.py. Follower/following calculation...

Compare with previous version

Dariusz Kędzierski added 1 commit 4 years ago

added 1 commit

f600eb27 - Removed unused imports

Compare with previous version

Dariusz Kędzierski added 1 commit 4 years ago

added 1 commit

ddf50cf3 - Adding block number to follow update operation caused chages in notification patters.

Compare with previous version

Dariusz Kędzierski added 4 commits 4 years ago

added 4 commits

ddf50cf3...13868a13 - 3 commits from branch develop
9db7c6b2 - Rebase to current develop

Compare with previous version

Please register or sign in to reply