pylint wip

hive/indexer/utils.py

@@ -7,8 +7,8 @@ from toolz import update_in, assoc
 from datetime import datetime
 from steembase.http_client import HttpClient
 
-def amount(str):
-    return float(str.split(' ')[0])
+def amount(string):
+    return float(string.split(' ')[0])
 
 def parse_time(block_time):
     return datetime.strptime(block_time, '%Y-%m-%dT%H:%M:%S')
@@ -16,7 +16,7 @@ def parse_time(block_time):
 # https://github.com/steemit/steem-python/blob/master/steem/utils.py
 def json_expand(json_op, key_name='json'):
     """ Convert a string json object to Python dict in an op. """
-    if type(json_op) == dict and key_name in json_op and json_op[key_name]:
+    if isinstance(json_op, dict) and key_name in json_op and json_op[key_name]:
         try:
             return update_in(json_op, [key_name], json.loads)
         except JSONDecodeError:
@@ -85,4 +85,3 @@ class SteemAdapter:
 
     def __exec(self, method, *params):
         return self._client.exec(method, *params)
-

pylintrc

@@ -65,7 +65,61 @@ confidence=
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use"--disable=all --enable=classes
 # --disable=W"
-disable=range-builtin-not-iterating,filter-builtin-not-iterating,raising-string,no-absolute-import,round-builtin,old-raise-syntax,nonzero-method,hex-method,import-star-module-level,zip-builtin-not-iterating,delslice-method,basestring-builtin,coerce-builtin,file-builtin,unicode-builtin,unpacking-in-except,apply-builtin,print-statement,parameter-unpacking,next-method-called,indexing-exception,reduce-builtin,reload-builtin,map-builtin-not-iterating,old-octal-literal,backtick,old-ne-operator,intern-builtin,suppressed-message,raw_input-builtin,execfile-builtin,old-division,buffer-builtin,dict-view-method,dict-iter-method,metaclass-assignment,useless-suppression,cmp-method,input-builtin,standarderror-builtin,unichr-builtin,cmp-builtin,long-suffix,getslice-method,long-builtin,xrange-builtin,using-cmp-argument,setslice-method,oct-method,coerce-method
+disable=
+    # custom
+    missing-docstring,
+
+    # default
+    range-builtin-not-iterating,
+    filter-builtin-not-iterating,
+    raising-string,
+    no-absolute-import,
+    round-builtin,
+    old-raise-syntax,
+    nonzero-method,
+    hex-method,
+    import-star-module-level,
+    zip-builtin-not-iterating,
+    delslice-method,
+    basestring-builtin,
+    coerce-builtin,
+    file-builtin,
+    unicode-builtin,
+    unpacking-in-except,
+    apply-builtin,
+    print-statement,
+    parameter-unpacking,
+    next-method-called,
+    indexing-exception,
+    reduce-builtin,
+    reload-builtin,
+    map-builtin-not-iterating,
+    old-octal-literal,
+    backtick,
+    old-ne-operator,
+    intern-builtin,
+    suppressed-message,
+    raw_input-builtin,
+    execfile-builtin,
+    old-division,
+    buffer-builtin,
+    dict-view-method,
+    dict-iter-method,
+    metaclass-assignment,
+    useless-suppression,
+    cmp-method,
+    input-builtin,
+    standarderror-builtin,
+    unichr-builtin,
+    cmp-builtin,
+    long-suffix,
+    getslice-method,
+    long-builtin,
+    xrange-builtin,
+    using-cmp-argument,
+    setslice-method,
+    oct-method,
+    coerce-method
 
 
 [REPORTS]