Update list_subscribers to order by name instead of by id

hive/db/sql_scripts/postgrest/bridge_api/bridge_api_list_subscribers.sql

@@ -8,7 +8,7 @@ $$
 DECLARE
     _community_id INT;
     _community TEXT;
-    _subscription_id INT;
+    _last_name TEXT;
     _limit INTEGER := 100;
 BEGIN
     _params = hivemind_postgrest_utilities.validate_json_arguments(_params, '{"community": "string", "last": "string", "limit": "number"}', 1, '{"community": "given community name is not valid"}');
@@ -17,13 +17,14 @@ BEGIN
     _community = hivemind_postgrest_utilities.valid_community(_community);
     _community_id = hivemind_postgrest_utilities.find_community_id(_community, True);
 
-    _subscription_id =
-      hivemind_postgrest_utilities.find_subscription_id(
-        hivemind_postgrest_utilities.valid_account(
-          hivemind_postgrest_utilities.parse_argument_from_json(_params, 'last', False),
-          True),
-        _community,
-        True);
+    _last_name = hivemind_postgrest_utilities.valid_account(
+        hivemind_postgrest_utilities.parse_argument_from_json(_params, 'last', False),
+        True
+    );
+
+    IF _last_name IS NOT NULL THEN
+        PERFORM hivemind_postgrest_utilities.find_subscription_id(_last_name,  _community, True); -- Check that account exists and is subscribed to the community
+    END IF;
 
     _limit = hivemind_postgrest_utilities.parse_integer_argument_from_json(_params, 'limit', False);
     _limit = hivemind_postgrest_utilities.valid_number(_limit, 100, 1, 100, 'limit');
@@ -40,7 +41,8 @@ BEGIN
           LEFT JOIN hivemind_app.hive_roles hr ON hs.account_id = hr.account_id
                AND hs.community_id = hr.community_id
           JOIN hivemind_app.hive_accounts ha ON hs.account_id = ha.id
-          WHERE hs.community_id = _community_id AND (_subscription_id = 0 OR (hs.id < _subscription_id))
+          WHERE hs.community_id = _community_id
+          AND (_last_name IS NULL OR ha.name COLLATE "C" > _last_name COLLATE "C")
           ORDER BY ha.name ASC
           LIMIT _limit
        ) row
@@ -48,5 +50,4 @@ BEGIN
       '[]'::JSONB
     );
 END
-$$
-;
\ No newline at end of file
+$$;
\ No newline at end of file

tests/api_tests/hivemind/tavern/bridge_api_patterns/list_subscribers/hive-165317_last_abit.pat.json

 [
+  [
+    "agartha",
+    "guest",
+    null,
+    "2016-09-15T18:02:03"
+  ],
   [
     "alice",
     "guest",
@@ -29,4 +35,4 @@
     null,
     "2016-09-15T18:01:48"
   ]
-]
+]
\ No newline at end of file

tests/api_tests/hivemind/tavern/bridge_api_patterns/list_subscribers/hive-165317_last_alice.pat.json

 [
+  [
+    "camilla",
+    "guest",
+    null,
+    "2016-09-15T18:01:57"
+  ],
   [
     "good-karma",
     "guest",
     null,
     "2016-09-15T18:01:51"
   ],
+  [
+    "gtg",
+    "guest",
+    null,
+    "2016-09-15T18:02:00"
+  ],
   [
     "test-safari",
     "guest",
     null,
     "2016-09-15T18:01:48"
   ]
-]
+]
\ No newline at end of file

tests/api_tests/hivemind/tavern/bridge_api_patterns/list_subscribers/hive-165317_last_gtg.pat.json

 [
-  [
-    "alice",
-    "guest",
-    null,
-    "2016-09-15T18:01:54"
-  ],
-  [
-    "camilla",
-    "guest",
-    null,
-    "2016-09-15T18:01:57"
-  ],
-  [
-    "good-karma",
-    "guest",
-    null,
-    "2016-09-15T18:01:51"
-  ],
   [
     "test-safari",
     "guest",
     null,
     "2016-09-15T18:01:48"
   ]
-]
+]
\ No newline at end of file

tests/api_tests/hivemind/tavern/bridge_api_patterns/list_subscribers/hive-186669_last_roadscape.pat.json → tests/api_tests/hivemind/tavern/bridge_api_patterns/list_subscribers/hive-186669_last_gtg.pat.json

 [
   [
-    "gtg",
+    "roadscape",
     "guest",
     null,
     "2016-09-15T18:01:48"
   ]
-]
+]
\ No newline at end of file

tests/api_tests/hivemind/tavern/bridge_api_patterns/list_subscribers/hive-186669_last_roadscape.tavern.yaml → tests/api_tests/hivemind/tavern/bridge_api_patterns/list_subscribers/hive-186669_last_gtg.tavern.yaml

@@ -19,7 +19,7 @@
           jsonrpc: "2.0"
           id: 1
           method: "bridge.list_subscribers"
-          params: {"community":"hive-186669", "last":"roadscape"}
+          params: {"community":"hive-186669", "last":"gtg"}
       response:
         status_code: 200
         verify_response_with:

tests/api_tests/hivemind/tavern/bridge_api_patterns/list_subscribers/paginated.pat.json

 [
-  [
-    "gtg",
-    "guest",
-    null,
-    "2016-09-15T18:01:48"
-  ],
   [
     "test-safari",
     "admin",
     "",
     "2016-09-15T18:01:48"
   ]
-]
+]
\ No newline at end of file

tests/api_tests/hivemind/tavern/bridge_api_patterns/list_subscribers/paginated_limit_1.pat.json

 [
   [
-    "gtg",
-    "guest",
-    null,
+    "test-safari",
+    "admin",
+    "",
     "2016-09-15T18:01:48"
   ]
-]
+]
\ No newline at end of file