Postgrest - restore LIMIT in queres which uses CTE and limit, appears that...

Postgrest - restore LIMIT in queres which uses CTE and limit, appears that it's important for query efficiency

hive/db/sql_scripts/postgrest/bridge_api/bridge_api_account_notifications.sql

@@ -93,6 +93,7 @@ BEGIN
                 ELSE hivemind_app.get_number_of_mentions_in_post( hnv.post_id )
             END as mentions
         ) as hm
+        LIMIT _limit
       ) hive_notification_cache
   );
 END

hive/db/sql_scripts/postgrest/bridge_api/bridge_api_get_post.sql

-DROP FUNCTION IF EXISTS hivemind_endpoints.bridge_api_get_posts;
-CREATE FUNCTION hivemind_endpoints.bridge_api_get_posts(IN _json_is_object BOOLEAN, IN _params JSONB)
+DROP FUNCTION IF EXISTS hivemind_endpoints.bridge_api_get_post;
+CREATE FUNCTION hivemind_endpoints.bridge_api_get_post(IN _json_is_object BOOLEAN, IN _params JSONB)
 RETURNS JSONB
 LANGUAGE 'plpgsql'
 STABLE

hive/db/sql_scripts/postgrest/bridge_api/bridge_api_post_notifications.sql

@@ -88,6 +88,7 @@ BEGIN
             END as mentions
         ) as hm
         ORDER BY hnv.id DESC
+        LIMIT _limit
       )
       SELECT
         notifications.id,
@@ -104,6 +105,7 @@ BEGIN
           END
         ) AS url
       FROM notifications
+      LIMIT _limit
     ) row
   );
 END

hive/db/sql_scripts/postgrest/condenser_api/condenser_api_get_blog.sql

@@ -85,6 +85,7 @@ BEGIN
         JOIN hivemind_app.hive_accounts ha ON ha.id = hp.author_id
         JOIN hivemind_app.hive_permlink_data hpd ON hpd.id = hp.permlink_id
         ORDER BY blog.created_at DESC, blog.post_id DESC
+        LIMIT _limit
       ) row
     );
   ELSE
@@ -147,6 +148,7 @@ BEGIN
         LATERAL hivemind_app.get_post_view_by_id(blog.post_id) hp
         -- in python code order was ASC, but because we append new elements to array in reverse order, order is DESC here
         ORDER BY blog.created_at DESC, blog.post_id DESC
+        LIMIT _limit
       ) row      
     );
   END IF;

hive/db/sql_scripts/postgrest/condenser_api/condenser_api_get_discussion_by_author_before_date.sql

@@ -100,6 +100,7 @@ BEGIN
       FROM blog_posts,
       LATERAL hivemind_app.get_post_view_by_id(blog_posts.id) hp
       ORDER BY hp.id DESC
+      LIMIT _limit
     ) row
   );
 

hive/db/sql_scripts/postgrest/condenser_api/condenser_api_get_following.sql

@@ -49,6 +49,7 @@ BEGIN
         FROM following_set fs
         JOIN hivemind_app.hive_accounts ha ON fs.following = ha.id
         ORDER BY fs.id DESC
+        LIMIT (_params->'limit')::INT
       ) row
     ),
     '[]'::jsonb

hive/db/sql_scripts/postgrest/condenser_api/condenser_api_get_trending_tags.sql

@@ -42,7 +42,7 @@ _result = (
       ORDER BY SUM(hp.payout + hp.pending_payout) DESC, hcd.category ASC
       LIMIT _limit
     )
-    SELECT name, comments - top_posts AS comments, top_posts, total_payouts FROM row
+    SELECT name, comments - top_posts AS comments, top_posts, total_payouts FROM row LIMIT _limit
   ) row
 );
 

hive/db/sql_scripts/postgrest/database_api/database_api_find_comments.sql

@@ -96,6 +96,7 @@ BEGIN
                         pv.parent_author
                       FROM posts,
                       LATERAL hivemind_app.get_post_view_by_id (posts.id) pv
+                      LIMIT _comments_amount
                     ) row
                   )
     )

hive/db/sql_scripts/postgrest/utilities/get_account_posts.sql

@@ -90,6 +90,7 @@ BEGIN
       FROM blog,
       LATERAL hivemind_app.get_post_view_by_id(blog.post_id) hp
       ORDER BY blog.created_at DESC, blog.post_id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -178,6 +179,7 @@ BEGIN
       FROM ds,
       LATERAL hivemind_app.get_post_view_by_id(ds.id) hp
       ORDER BY ds.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -279,6 +281,7 @@ BEGIN
         FROM feed,
         LATERAL hivemind_app.get_post_view_by_id(feed.post_id) hp
         ORDER BY feed.min_created DESC, feed.post_id DESC
+        LIMIT _limit
       ) row
     );
 
@@ -363,6 +366,7 @@ BEGIN
       FROM posts,
       LATERAL hivemind_app.get_post_view_by_id(posts.id) hp
       ORDER BY posts.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -454,6 +458,7 @@ BEGIN
       FROM replies,
       LATERAL hivemind_app.get_post_view_by_id(replies.id) hp
       ORDER BY replies.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -546,6 +551,7 @@ BEGIN
       FROM payouts,
       LATERAL hivemind_app.get_post_view_by_id(payouts.id) hp
       ORDER BY payouts.total_payout DESC, payouts.id DESC
+      LIMIT _limit
     ) row
   );
 

hive/db/sql_scripts/postgrest/utilities/get_api_method.sql

@@ -114,7 +114,7 @@ BEGIN
     WHEN __method_type = 'get_community_context' THEN
       result := hivemind_endpoints.bridge_api_get_community_context(__json_with_params_is_object, __params);
     WHEN __method_type = 'get_post' THEN
-      result := hivemind_endpoints.bridge_api_get_posts(__json_with_params_is_object, __params);
+      result := hivemind_endpoints.bridge_api_get_post(__json_with_params_is_object, __params);
     WHEN __method_type = 'get_payout_stats' THEN
       result := hivemind_endpoints.bridge_api_get_payout_stats(__json_with_params_is_object, __params);
     WHEN __method_type = 'get_account_posts' THEN
@@ -141,7 +141,7 @@ BEGIN
       result := hivemind_endpoints.bridge_api_get_posts_header(__json_with_params_is_object, __params);
     WHEN __method_type = 'normalize_post' THEN
       -- according to python code, there are no checks if anything is good, just extract author & permlink and call get_post
-      result := hivemind_endpoints.bridge_api_get_posts(True, jsonb_build_object('author', __params->'post'->>'author', 'permlink', __params->'post'->>'permlink'));
+      result := hivemind_endpoints.bridge_api_get_post(True, jsonb_build_object('author', __params->'post'->>'author', 'permlink', __params->'post'->>'permlink'));
     WHEN __method_type = 'get_profile' THEN
       result := hivemind_endpoints.bridge_api_get_profile(__json_with_params_is_object, __params);
     WHEN __method_type = 'list_muted_reasons_enum' THEN

hive/db/sql_scripts/postgrest/utilities/get_ranked_posts.sql

@@ -90,6 +90,7 @@ BEGIN
         FROM pinned_post,
         LATERAL hivemind_app.get_post_view_by_id(pinned_post.id) hp
         ORDER BY hp.id DESC
+        LIMIT _limit
       ) row
     );
   END IF;
@@ -204,6 +205,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(community_posts.id) hp
       ORDER BY
         hp.sc_trend DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -296,6 +298,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(community_posts.id) hp
       ORDER BY
         hp.promoted DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -393,6 +396,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(community_posts.id) hp
       ORDER BY
         community_posts.total_payout DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -487,6 +491,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(community_posts.id) hp
       ORDER BY
         community_posts.total_payout DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -580,6 +585,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(community_posts.id) hp
       ORDER BY
         hp.sc_hot DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -681,6 +687,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(community_posts.id) hp
       ORDER BY
         community_posts.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -770,6 +777,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(community_posts.id) hp
       ORDER BY
         community_posts.total_payout DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -866,6 +874,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(tag_posts.id) hp
       ORDER BY
         hp.sc_trend DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -961,6 +970,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(tag_posts.id) hp
       ORDER BY
         hp.sc_hot DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -1053,6 +1063,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(tag_posts.id) hp
       ORDER BY
         hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -1148,6 +1159,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(tag_posts.id) hp
       ORDER BY
         hp.promoted DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -1246,6 +1258,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(tag_posts.id) hp
       ORDER BY
         tag_posts.total_payout DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -1342,6 +1355,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(tag_posts.id) hp
       ORDER BY
         tag_posts.total_payout DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -1434,6 +1448,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(tag_posts.id) hp
       ORDER BY
         tag_posts.total_payout DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -1522,6 +1537,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(observer_posts.id) hp
       ORDER BY
         hp.sc_trend DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -1610,6 +1626,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(observer_posts.id) hp
       ORDER BY
         hp.sc_hot DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -1694,6 +1711,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(observer_posts.id) hp
       ORDER BY
         hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -1782,6 +1800,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(observer_posts.id) hp
       ORDER BY
         hp.promoted DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -1875,6 +1894,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(observer_posts.id) hp
       ORDER BY
         observer_posts.total_payout DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -1964,6 +1984,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(observer_posts.id) hp
       ORDER BY
         observer_posts.total_payout DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -2053,6 +2074,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(observer_posts.id) hp
       ORDER BY
         observer_posts.total_payout DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -2145,6 +2167,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(all_posts.id) hp
       ORDER BY
         hp.sc_trend DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -2236,6 +2259,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(all_posts.id) hp
       ORDER BY
         hp.sc_hot DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -2324,6 +2348,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(all_posts.id) hp
       ORDER BY
         hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -2416,6 +2441,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(all_posts.id) hp
       ORDER BY
         hp.promoted DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -2513,6 +2539,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(all_posts.id) hp
       ORDER BY
         (hp.payout + hp.pending_payout) DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -2606,6 +2633,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(all_posts.id) hp
       ORDER BY
         (hp.payout + hp.pending_payout) DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 
@@ -2693,6 +2721,7 @@ BEGIN
       LATERAL hivemind_app.get_post_view_by_id(all_posts.id) hp
       ORDER BY
         (hp.payout + hp.pending_payout) DESC, hp.id DESC
+      LIMIT _limit
     ) row
   );
 

hive/db/sql_scripts/postgrest/utilities/list_comments.sql

@@ -90,6 +90,7 @@ BEGIN
                         FROM comments,
                         LATERAL hivemind_app.get_post_view_by_id(comments.id) hp
                         ORDER BY comments.cashout_time ASC, comments.id ASC
+                        LIMIT _limit
                       ) row
                     )
         )
@@ -200,6 +201,7 @@ BEGIN
                       FROM comments,
                       LATERAL hivemind_app.get_post_view_by_id(comments.id) hp
                       ORDER BY comments.id
+                      LIMIT _limit
                     ) row
                   )
         )
@@ -309,6 +311,7 @@ BEGIN
                       FROM comments,
                       LATERAL hivemind_app.get_post_view_by_id(comments.id) hp
                       ORDER BY comments.updated_at DESC, comments.id ASC
+                      LIMIT _limit
                     ) row
                   )
         )
@@ -418,6 +421,7 @@ BEGIN
                       FROM comments,
                       LATERAL hivemind_app.get_post_view_by_id(comments.id) hp
                       ORDER BY comments.updated_at DESC, comments.id ASC
+                      LIMIT _limit
                     ) row
                   )
         )
@@ -522,6 +526,7 @@ BEGIN
                       FROM comments,
                       LATERAL hivemind_app.get_post_view_by_id(comments.id) hp
                       ORDER BY hp.author, hp.permlink
+                      LIMIT _limit
                     ) row
                   )
         )