Skip to content

Fixes & improvements of log file appender"

Closes #515 (closed)

Related MR test-tools!147 (merged)

  • Fixes broken log file rotation by spawning a dedicated logging_thread that allows _rotation_task to be correctly scheduled & executed.
    You can see the results in logs/p2p subdirectory of hived working folder - with standard configuration new log files are created every hour and deleted when empty or obsolete (one day old).
  • Fixes a bug that prevented empty/obsolete file removal.
  • Enables usage of several attributes in log file appender configuration JSON. They were previously overridden by hardcoded values, which are now used as default ones for backward compatibility.
  • Documents the enabled attributes in help printed by hived and in generated default config.ini file.
  • Enables wider printing of help by hived.
  • Enables standard way of specifying many appenders for one logger (replacing "appender" string JSON attribute with "appenders" array one).
  • Adds unit tests that verify
    • default configuration (as printed in help or config.ini)
    • custom configuration - that enabled attributes are no longer overridden by hardcoded values
    • that actual log file rotation takes place
Edited by Łukasz Bujak

Merge request reports