beekeeper | Beekeeper sends `signals attached` notify too early
Some time ago, the beekeeper sent information about its readiness, by sending signals attached
notification.
Currently, beekeeper still sends it, but it does it too early even before the notification server is set, it is an issue because clive depends on this signal.
log:
(develop *)(default) $ ./beekeeper --notifications-endpoint 127.0.0.1:8000 --webserver-http-endpoint 127.0.0.1:6666
**3366689ms beekeeper_app.cpp:16 beekeeper_app ] Sending 'signals attached' signals**
3366689ms json_rpc_plugin.cpp:238 initialize ] initializing JSON RPC plugin
3366689ms json_rpc_plugin.cpp:200 add_api_method ] api_name: jsonrpc method_name: get_methods
3366689ms json_rpc_plugin.cpp:200 add_api_method ] api_name: jsonrpc method_name: get_signature
3366689ms webserver_plugin.cpp:587 plugin_initialize ] initializing webserver plugin
3366689ms webserver_plugin.cpp:590 plugin_initialize ] configured with 32 thread pool size
3366689ms webserver_plugin.cpp:593 plugin_initialize ] Compression in webserver is disabled
3366690ms webserver_plugin.cpp:605 plugin_initialize ] configured http to listen on 127.0.0.1:6666
3366690ms beekeeper_app_init.cpp:49 initialize_program_o ] initializing options
3366690ms notifications.cpp:65 setup ] setting up notification handler for 1 address
3366693ms beekeeper_app_init.cpp:72 initialize_program_o ] Backtrace on segfault is enabled.
3366693ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: create
3366693ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: open
3366693ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: close
3366693ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: set_timeout
3366693ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: lock_all
3366694ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: lock
3366694ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: unlock
3366694ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: import_key
3366694ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: remove_key
3366694ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: list_wallets
3366694ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: list_created_wallets
3366694ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: get_public_keys
3366694ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: sign_digest
3366694ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: get_info
3366694ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: create_session
3366694ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: close_session
3366694ms json_rpc_plugin.cpp:200 add_api_method ] api_name: beekeeper_api method_name: has_matching_private_key
3366694ms application.cpp:110 startup ] Startup...
3366694ms webserver_plugin.cpp:293 operator() ] start processing http thread
3366694ms webserver_plugin.cpp:308 operator() ] start listening for http requests on 127.0.0.1:6666
The first log entry was generated by adding a simple log snippet
beekeeper_app::beekeeper_app()
{
wlog("Sending 'signals attached' signals");
app.init_signals_handler();
}
@Trela said that this notification is no longer needed because it was used only to send info that the SIGINT handler is set, so it should be removed. Because it is not possible to even get this notification.
Additionally, we should send notification about beekeepers readiness - like beekeeper is ready
or everything is done
, it would be sent after beekeeper is starting
notification.