Code without effect
If I understand correctly, this code has no effect and can be removed.
From this fixture in hive/tests/functional/python_tests/direct_rc_delegations_tests/conftest.py
:
@pytest.fixture
def node(request):
init_node = tt.InitNode()
# The actual HF time does not matter as long as it's in the past
shared_file_size = request.node.get_closest_marker('node_shared_file_size')
if shared_file_size:
init_node.config.shared_file_size = shared_file_size.args[0]
init_node.run(environment_variables={"HIVE_HF26_TIME": "1598558400"})
return init_node
Should be removed:
- comment "The actual HF time does not matter as long as it's in the past",
-
HIVE_HF26_TIME=1598558400
environment variable.
If I am right (please @bwrona or @ABW) check it, you know how HIVE_HF26_TIME
works, this code would look like:
@pytest.fixture
def node(request):
init_node = tt.InitNode()
shared_file_size = request.node.get_closest_marker('node_shared_file_size')
if shared_file_size:
init_node.config.shared_file_size = shared_file_size.args[0]
init_node.run()
return init_node
Then please show it to @kudmich, because it is possible, that his universal-node
(as he names it) do everything what is needed here, and this fixture might be completely removed.