Skip to content

Remove PYTHONPATH hack when requiring test-tools

Mateusz Żebrak requested to merge mzebrak/fix-test-tools-tox-installation into develop

For updating HIVE submodule, it requires: hive!769 (merged)

Test-tools have it's own dependencies like requests or recently added python-dateutil.

When using hack by injecting test_tools/package/ into to PYTHONPATH env variable, these dependencies are not installed and it is required to specify them explicitly in the deps section of tox.ini.

This could lead to mismatch between test-tools and tox.ini versions of dependencies, so this change makes test-tools installable inside tox instead of using it's source code directly.

Additionaly, some dependencies might not be even included so pipeline will fail immediatelly. Such situation takes place when test-tools introduce new, mandatory dependencies, like recently python-dateutil. Pipeline not failed just by luck, because other dependency (pandas) was installing python-dateutil. If pandas would not install it, pipeline will fail in such way (ModuleNotFoundError: No module named ...).

This MR fixes it and installs test-tools (including all of their required deps) by specifing theirs path in tox.ini deps section.

Now they are installed and it could be observed here
The line 623 shows it:
py38 installdeps: pytest==6.2.5, pytest-timeout==2.0.1, pytest-repeat==0.9.1, sqlalchemy==1.4.25, sqlalchemy-utils==0.37.9, psycopg2==2.9.1, requests==2.25.1, pandas==1.4.0, /builds/hive/haf/hive/tests/test_tools

FYI: @kudmich

Edited by Mateusz Żebrak

Merge request reports