change account.`posts` to `comments` in relevant routes/vars. Resolves #443 (#487)

app/ResolveRoute.js

@@ -53,7 +53,8 @@ export default function resolveRoute(path)
         return {page: 'PostsIndex', params: ['home', match[1]]};
     }
     match = path.match(/^\/(@[\w\.\d-]+)\/?$/) ||
-        path.match(/^\/(@[\w\.\d-]+)\/(blog|posts|recommended|transfers|curation-rewards|author-rewards|permissions|created|recent-replies|feed|password|followed|followers)\/?$/);
+        // @user/"posts" is deprecated in favor of "comments" as of oct-2016 (#443)
+        path.match(/^\/(@[\w\.\d-]+)\/(blog|posts|comments|recommended|transfers|curation-rewards|author-rewards|permissions|created|recent-replies|feed|password|followed|followers)\/?$/);
     if (match) {
         return {page: 'UserProfile', params: match.slice(1)};
     }

app/components/modules/Header.jsx

@@ -129,7 +129,8 @@ class Header extends React.Component {
             if(route.params[1] === "recent-replies"){
                 page_title = `Replies by ${user_name} `;
             }
-            if(route.params[1] === "posts"){
+            // @user/"posts" is deprecated in favor of "comments" as of oct-2016 (#443)
+            if(route.params[1] === "posts" || route.params[1] === "comments"){
                 page_title = `Comments by ${user_name} `;
             }
         } else {

app/components/modules/TopRightMenu.jsx

@@ -26,13 +26,13 @@ function TopRightMenu({username, showLogin, logout, loggedIn, showSignUp, userpi
     const replies_link = `/@${username}/recent-replies`;
     const wallet_link = `/@${username}/transfers`;
     const account_link = `/@${username}`;
-    const posts_link = `/@${username}/posts`;
+    const comments_link = `/@${username}/comments`;
     const reset_password_link = `/@${username}/password`;
     if (loggedIn) { // change back to if(username) after bug fix:  Clicking on Login does not cause drop-down to close #TEMP!
         const user_menu = [
             {link: feed_link, value: 'Feed'},
             {link: account_link, value: 'Blog'},
-            {link: posts_link, value: 'Comments'},
+            {link: comments_link, value: 'Comments'},
             {link: replies_link, value: 'Replies'},
             {link: wallet_link, value: 'Wallet'},
             {link: reset_password_link, value: 'Change Password'},

app/components/pages/UserProfile.jsx

@@ -41,7 +41,7 @@ export default class UserProfile extends React.Component {
         switch(category) {
           case 'feed': order = 'by_feed'; break;
           case 'blog': order = 'by_author'; break;
-          case 'posts': order = 'by_comments'; break;
+          case 'comments': order = 'by_comments'; break;
           case 'recent_replies': order = 'by_replies'; break;
           default: console.log('unhandled category:', category);
         }
@@ -61,6 +61,9 @@ export default class UserProfile extends React.Component {
         // const gprops = this.props.global.getIn( ['props'] ).toJS();
         if( !section ) section = 'blog';
 
+        // @user/"posts" is deprecated in favor of "comments" as of oct-2016 (#443)
+        if( section == 'posts' ) section = 'comments';
+
         // const isMyAccount = current_user ? current_user.get('username') === accountname : false;
         let account
         let accountImm = this.props.global.getIn(['accounts', accountname]);
@@ -145,14 +148,16 @@ export default class UserProfile extends React.Component {
                           />
             }
         }
-        else if( section === 'posts' && account.post_history ) {
+        else if( section === 'comments' && account.post_history ) {
+           // NOTE: `posts` key will be renamed to `comments` (https://github.com/steemit/steem/issues/507)
+           //   -- see also GlobalReducer.js
            if( account.posts )
            {
               tab_content = <PostsList
                   emptyText={`Looks like ${account.name} hasn't made any comments yet!`}
                   posts={account.posts}
                   loading={fetching}
-                  category="posts"
+                  category="comments"
                   loadMore={this.loadMore}
                   showSpam />;
            }
@@ -204,19 +209,7 @@ export default class UserProfile extends React.Component {
         }
 
         let printLink = null;
-        let section_title = account.name + ' / ' + section;
-        if( section === 'blog' ) {
-           section_title = account.name + "'s blog";
-        } else if( section === 'transfers' ) {
-           section_title = account.name + "'s wallet";
-        } else if( section === 'curation-rewards' ) {
-          section_title = account.name + "'s curation rewards";
-      } else if( section === 'author-rewards' ) {
-        section_title = account.name + "'s author rewards";
-        } else if( section === 'password' ) {
-           section_title = ''
-        } else if( section === 'permissions' ) {
-           section_title = account.name + "'s permissions"
+        if( section === 'permissions' ) {
            if(isMyAccount && wifShown) {
                printLink = <div>
                    <a className="float-right noPrint" onClick={onPrint}>
@@ -225,10 +218,6 @@ export default class UserProfile extends React.Component {
                    </a>
                </div>
            }
-        } else if( section === 'posts' ) {
-           section_title = account.name + "'s posts";
-        } else if( section === 'recent-replies' ) {
-           section_title = 'Recent replies to ' + account.name + "'s posts";
         }
 
         const wallet_tab_active = section === 'transfers' || section === 'password' || section === 'permissions' ? 'active' : ''; // className={wallet_tab_active}
@@ -242,7 +231,7 @@ export default class UserProfile extends React.Component {
             <div className="columns small-10 medium-12 medium-expand">
                 <ul className="menu" style={{flexWrap: "wrap"}}>
                     <li><Link to={`/@${accountname}`} activeClassName="active">Blog</Link></li>
-                    <li><Link to={`/@${accountname}/posts`} activeClassName="active">Comments</Link></li>
+                    <li><Link to={`/@${accountname}/comments`} activeClassName="active">Comments</Link></li>
                     <li><Link to={`/@${accountname}/recent-replies`} activeClassName="active">Replies</Link></li>
                     {/*<li><Link to={`/@${accountname}/feed`} activeClassName="active">Feed</Link></li>*/}
                     <li>
@@ -304,7 +293,6 @@ export default class UserProfile extends React.Component {
                 </div>
                 <div className="row">
                     <div className="column">
-                        {/*section_title && <h2 className="UserProfile__section-title">{section_title}</h2>*/}
                         {tab_content}
                     </div>
                 </div>

app/redux/GlobalReducer.js

@@ -152,8 +152,9 @@ export default createModule({
                 // console.log('-- RECEIVE_DATA state -->', state.toJS());
                 let new_state;
                 if (order === 'by_author' || order === 'by_feed' || order === 'by_comments' || order === 'by_replies') {
-                    // category is either "blog", "feed", "posts", or "recent_replies" (respectively) -- and all posts are keyed under current profile
-                    const key = ['accounts', accountname, category]
+                    // category is either "blog", "feed", "comments", or "recent_replies" (respectively) -- and all posts are keyed under current profile
+                    // one exception: "comments" category is keyed as "posts" in get_state (https://github.com/steemit/steem/issues/507)
+                    const key = ['accounts', accountname, category == "comments" ? "posts" : category]
                     new_state = state.updateIn(key, List(), list => {
                         return list.withMutations(posts => {
                             data.forEach(value => {