TUI - random exeption after clicking Unlocked - different error

See #384 (closed)

I can't repeat. I did nothing unusual, I logged in and then after a while, I logged out.

Logs:

latest_2.log

Output was:

Status: Downloaded newer image for registry.gitlab.syncad.com/hive/clive:3c529315
Launching clive in TUI mode on mainnet
╭─────────────────────────────────────── Traceback (most recent call last) ───────────────────────────────────────╮
│ /clive-venv/lib/python3.10/site-packages/textual/worker.py:368 in _run │
│ │
│ 365 │ │ │ self.state = WorkerState.RUNNING │
│ 366 │ │ │ app.log.worker(self) │
│ 367 │ │ │ try: │
│ ❱ 368 │ │ │ │ self._result = await self.run() │
│ 369 │ │ │ except asyncio.CancelledError as error: │
│ 370 │ │ │ │ self.state = WorkerState.CANCELLED │
│ 371 │ │ │ │ self._error = error │
│ │
│ ╭────────────────────────────────────────────────── locals ───────────────────────────────────────────────────╮ │
│ │ app = Clive(title='Clive (Operations)', classes={'-dark-mode'}, pseudo_classes={'dark', 'focus'}) │ │
│ │ error = NoWorkingAccountError() │ │
│ │ self = <Worker │ │
│ │ │ ERROR │ │
│ │ │ name='_attribute_changed' │ │
│ │ │ description='<coroutine object DynamicWidget._attribute_changed at 0x7f15918d4eb0>' │ │
│ │ > │ │
│ │ worker_failed = WorkerFailed('Worker raised exception: NoWorkingAccountError()') │ │
│ ╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
│ /clive-venv/lib/python3.10/site-packages/textual/worker.py:352 in run │
│ │
│ 349 │ │ Returns: │
│ 350 │ │ │ Return value of the work. │
│ 351 │ │ """ │
│ ❱ 352 │ │ return await ( │
│ 353 │ │ │ self._run_threaded() if self._thread_worker else self._run_async() │
│ 354 │ │ ) │
│ 355 │
│ │
│ ╭──────────────────────────────────────────── locals ────────────────────────────────────────────╮ │
│ │ self = <Worker │ │
│ │ │ ERROR │ │
│ │ │ name='_attribute_changed' │ │
│ │ │ description='<coroutine object DynamicWidget._attribute_changed at 0x7f15918d4eb0>' │ │
│ │ > │ │
│ ╰────────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
│ /clive-venv/lib/python3.10/site-packages/textual/worker.py:339 in _run_async │
│ │
│ 336 │ │ ): │
│ 337 │ │ │ return await self._work() │
│ 338 │ │ elif inspect.isawaitable(self._work): │
│ ❱ 339 │ │ │ return await self._work │
│ 340 │ │ elif callable(self._work): │
│ 341 │ │ │ raise WorkerError("Request to run a non-async function as an async worker") │
│ 342 │ │ raise WorkerError("Unsupported attempt to run an async worker") │
│ │
│ ╭──────────────────────────────────────────── locals ────────────────────────────────────────────╮ │
│ │ self = <Worker │ │
│ │ │ ERROR │ │
│ │ │ name='_attribute_changed' │ │
│ │ │ description='<coroutine object DynamicWidget._attribute_changed at 0x7f15918d4eb0>' │ │
│ │ > │ │
│ ╰────────────────────────────────────────────────────────────────────────────────────────────────╯ │
│ │
│ /clive-venv/lib/python3.10/site-packages/clive/__private/ui/widgets/dynamic_widgets/dynamic_widget.py:103 in │
│ _attribute_changed │
│ │
│ 100 │ │ if not should_update: │
│ 101 │ │ │ return │
│ 102 │ │ │
│ ❱ 103 │ │ result = self._call_with_arbitrary_args(callback, old_value, value) │
│ 104 │ │ if isawaitable(result): │
│ 105 │ │ │ result_ = await result │
│ 106 │ │ else: │
│ │
│ ╭──────────────────────────────────── locals ─────────────────────────────────────╮ │
│ │ old_value = <clive.__private.core.profile.Profile object at 0x7f1592511960> │ │
│ │ self = DynamicLabel() │ │
│ │ should_update = True │ │
│ │ value = <clive.__private.core.profile.Profile object at 0x7f1591ae3520> │ │
│ ╰─────────────────────────────────────────────────────────────────────────────────╯ │
│ │
│ /clive-venv/lib/python3.10/site-packages/clive/__private/ui/widgets/dynamic_widgets/dynamic_widget.py:138 in │
│ _call_with_arbitrary_args │
│ │
│ 135 │ │ if param_count == 2: # noqa: PLR2004 │
│ 136 │ │ │ return cast(WatchLikeCallbackBothValuesType[Any], callback)(old_value, value │
│ 137 │ │ if param_count == 1: │
│ ❱ 138 │ │ │ return cast(WatchLikeCallbackNewValueType[Any], callback)(value) │
│ 139 │ │ │
│ 140 │ │ return cast(WatchLikeCallbackNoArgsType[Any], callback)() │
│ 141 │
│ │
│ ╭─────────────────────────────────── locals ────────────────────────────────────╮ │
│ │ old_value = <clive.__private.core.profile.Profile object at 0x7f1592511960> │ │
│ │ param_count = 1 │ │
│ │ self = DynamicLabel() │ │
│ │ value = <clive.__private.core.profile.Profile object at 0x7f1591ae3520> │ │
│ ╰───────────────────────────────────────────────────────────────────────────────╯ │
│ │
│ /clive-venv/lib/python3.10/site-packages/clive/__private/ui/screens/cart_based_screen/cart_overview.py:106 in │
│ _get_hive_balance │
│ │
│ 103 │ │
│ 104 │ @staticmethod │
│ 105 │ def _get_hive_balance(profile: Profile) -> str: │
│ ❱ 106 │ │ return Asset.pretty_amount(profile.accounts.working.data.hive_balance) │
│ 107 │ │
│ 108 │ @staticmethod │
│ 109 │ def _get_hbd_balance(profile: Profile) -> str: │
│ │
│ ╭───────────────────────────────── locals ──────────────────────────────────╮ │
│ │ profile = <clive.__private.core.profile.Profile object at 0x7f1591ae3520> │ │
│ ╰───────────────────────────────────────────────────────────────────────────╯ │
│ │
│ /clive-venv/lib/python3.10/site-packages/clive/__private/core/accounts/account_manager.py:68 in working │
│ │
│ 65 │ │ │ NoWorkingAccountError: If no working account is set. │
│ 66 │ │ """ │
│ 67 │ │ if not self.has_working_account: │
│ ❱ 68 │ │ │ raise NoWorkingAccountError │
│ 69 │ │ assert self._working_account is not None, "Working account should be ensured by │
│ 70 │ │ return self._working_account │
│ 71 │
│ │
│ ╭──────────────────────────────────────────── locals ────────────────────────────────────────────╮ │
│ │ self = <clive.__private.core.accounts.account_manager.AccountManager object at 0x7f1591921ba0> │ │
│ ╰────────────────────────────────────────────────────────────────────────────────────────────────╯ │
╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
NoWorkingAccountError

Looks like that's caused by DynamicWidget because it schedules some action to be done in a separate task (worker) and there is another race condition.

1. New data received
2. Profile watchers are called
3. Dynamic widget schedules callback to be done in a separate worker
4. Meantime Lock happens - profile is set to welcome profile (soon will be set to None - !558 (merged))
5. Callback runs, but profile is in a different state

I think this can be fixed either by canceling all the workers when going into locked like

self.workers.cancel_all()

or canceling a specific group of DynamicWidget:

self.workers.cancel_group("dynamic_widget_update")

while also setting that group while the work is delegated: https://gitlab.syncad.com/hive/clive/blob/3289de4f6f9e0473ea6efb7afd5fc303d5e67c8c/clive/__private/ui/widgets/dynamic_widgets/dynamic_widget.py#L75

changed title from TUI - random exeption agrter clicking Unlocked - different error to TUI - random exeption after clicking Unlocked - different error

mentioned in commit 83d63e29

mentioned in merge request !602 (merged)

mentioned in commit 613063da

mentioned in commit 6c767389

mentioned in commit 60d70f14

closed with merge request !602 (merged)

mentioned in merge request !600 (merged)

changed milestone to %Release v1.27.5.21