Skip to content

Issue #372 - Handle mirroring properly, fixing go to last page and first page,...

Dima Rifai requested to merge delrifai/#372_handle_pagination_properly into develop

  1. Set isMirrored to false as default

  2. Fixed the logic around isMirrored and kept

  3. In case of one-page result, hide the pagination

  4. Fixed the go to last page and first page functionality

Testing notes:

Tested change across the following pages:

  1. Account >> Account Top Bar >> The navigation to the last page and the first page was not working as expected => Fixed
    1. Pagination was set to Mirrored since the data coming from the API is sorted by desc and we cannot control the sort direction https://hafbe.openhive.network/?urls.primaryName=HAfAH#/Accounts/hafah_endpoints.get_ops_by_account.
  2. Home page >> search account >> The navigation to the last page and the first page was not working as expected => Fixed
    1. Pagination was set to Mirrored since the data coming from the API is sorted by desc and we cannot control the sort direction https://hafbe.openhive.network/?urls.primaryName=HAfAH#/Accounts/hafah_endpoints.get_ops_by_account.
  3. Home page >> search comments >> The pagination was mirrored and not working as expected => Fixed by removing mirroring and fixing the navigation to the last and first pages
  4. Voters Dialogue >> The navigation to the last page and the first page was not working as expected => Fixed
  5. Voters History >> See #372 (comment 187803)
  6. Block page >> See #372 (comment 187803)
  7. Comments search result page >> from home page >> search comment >> go to results page => Fixed

Merge request reports