Operation Types not always showing in account view

This has been a bit hard to reproduce, but it seems to mostly affect "brave" browser. When you open an account view page by using the URL, sometimes the "Operation Type" filtering button does not show.

See screenshot below (the button should show inside the yellow pagination ribbon, next to the >> )

added To Do bug labels

assigned to @delrifai

removed To Do label

added Doing label

@mcfarhat this might be because of failed operation types request, so if it fails, it won't even show Operation types button, because there won't be anything to show there. Question if we want to have alternative for that?

@lbudginas could you explain a bit more, so is it possibly a failed API call that does not return code needed to display operation types button? because when the issue happens, a page refresh resolves it

Yeah that's my guess, I haven't looked deep into it. But if I remember correctly, component should return null if there is no operation types , so it makes sense that some times operations types button isn't visible. Especially if page refresh resolves this issue, it will send new request that's received successful response and that's why button becomes visible. So my guess is that request is failing which could happen for various reasons

@mcfarhat I will release this ticket for now if Lucas wants to work on it.

Thanks,

removed Doing label

added To Do label

unassigned @delrifai

assigned to @lbudginas

added Doing label and removed To Do label

@lbudginas not sure if you were able to reproduce this, but since the latest changes done on the positioning of this button i haven't came across the issue.

@mcfarhat

I was able to re-create it on current develop. Will wait for merges and try to recreate it again

Hello Team,

I had this issue again while working on another issue just now, it seems when I leave the page and then get back to it again this is happening.

I was able to trace till \components\account\tabs\operations\OperationsTabContent.tsx Line 72 accountOperationTypes was empty, so the button did not render. The name fromRoute was good but there were no results. I am using Explorer backend API:https://api.syncad.com

I could not complete tracing the issue because once a re-render occurred, the button showed again. Maybe an API issue? But also, the button disappeared after rendering when I left the screen and came back

const { accountOperationTypes } =
    useAccountOperationTypes(accountNameFromRoute);
    console.log(`accountNameFromRoute : ${accountNameFromRoute}` );
    console.log(accountOperationTypes);

Hi Dima, thanks, I'll take a look

mentioned in merge request !542 (merged)

added Review label and removed Doing label

removed Review label

added Doing label

removed Doing label

added Review label

@delrifai based on your prior testing, could you check if you can still reproduce the issue?

assigned to @delrifai and unassigned @lbudginas

Hello @mcfarhat ,

I have monitored this for the last couple of days, and it seems it is not happening anymore.

assigned to @mcfarhat and unassigned @delrifai

@mcfarhat I think this ticket can be closed as it did not happen again after Lukas's fix

closed