All calls to node should use Wax

getVestingDelegations method directly calls node. It goes against our principle to put all the node calls into Wax. The logic of changing nodes, validation and types is there. Please change the method to use it similar way to getRewardFunds, getDynamicGlobalProperties and getCurrentPriceFeed. Consender api is a part of Wax interfaces.

assigned to @mcfarhat

Thanks @jlachor for pointing this out, we will adjust accordingly

hey @jlachor , not sure why, but below condenser calls via wax appear to be returning empty results for both delegations (vesting and RC), could this be wax issue?

Trying out with account @actifit.funds for example which has both RC and vesting delegations, both returning empty sets. Trying with incorrect user names returns a non-existing user error so the params should be fine i believe.

await this.extendedHiveChain!.api.condenser_api.get_vesting_delegations
    ( [delegatorAccount, startAccount, limit]);

await this.extendedHiveChain!.api.condenser_api.list_rc_direct_delegations([[delegatorAccount, ""], limit]);

meanwhile below condenser call returns proper data

await this.extendedHiveChain!.api.condenser_api.get_accounts([[delegatorAccount]]);

noticed in dependencies this is the wax version

"@hiveio/wax": "^0.3.9-stable.240617105054",

assigned to @jlachor and unassigned @mcfarhat

hey @jlachor could you please check note above and let me know your thoughts?

jlachor is apparently on vacation, I'll try to find someone else to answer.

Sorry for late response @mcfarhat, I was off for a few days.

I adchanged ExplorerNodeApi accordingly to this:

type ExplorerNodeApi = {
  database_api: {
    get_reward_funds: TWaxApiRequest<{}, { funds: Hive.RewardFunds[] }>
    get_current_price_feed: TWaxApiRequest<{}, Hive.PriceFeed>
  },
  condenser_api: {
    get_vesting_delegations: TWaxApiRequest<[string, string | null, number], any>
    list_rc_direct_delegations: TWaxApiRequest<[[string, ""], number], any>
  }
}

And using those methods:

  async getVestingDelegations(delegatorAccount: string, startAccount: string | null, limit: number): Promise<any> {
    return await this.extendedHiveChain!.api.condenser_api.get_vesting_delegations([delegatorAccount, startAccount, limit]);
  }

  async getRcDelegations (delegatorAccount: string, limit: number): Promise<any> {
    return await this.extendedHiveChain!.api.condenser_api.list_rc_direct_delegations([[delegatorAccount, ""], limit]);
  }

Everything works fine. I checked network in browser and all calls are properly sent and the response is correct.

The difference is, that Wax cut all unnecessary stuff, which means you don't need to use result in hook or component. After cutting that part from AccountRcDelegationCard everything should be fine. Just get the direct data, not const delegations = rcDelegationsData?.result || []; this.

I have two more comments about that:

1. I want to have all the response types, not in any type. Please check what the usual response is and add it as new type to types/Hive file. If you have any troubles with fitting that into our system, just write to me and I'll help you.
2. Don't sort the data in component. Use select in React Query hooks instead. That is the proper place for it. You can check how selector is done in other hooks. We didn't had sorting there, but it should be really easy to expand it that way.

Thank you for your help and I hope this will be enough for you to finish this.

Thanks @jlachor ! we will review and feedback if we face further troubles

assigned to @mcfarhat and unassigned @jlachor

mentioned in merge request !367 (merged)

closed