Account balances should be displayed more prominently

sure @dan we're happy to take this on. A couple of thoughts:

Would you suggest we display the balance at the top next to or below the name, maybe in specific vesting and HBD balances? alternatively (or alongside), we could have the properties window open, maybe highlighting relevant financial fields, possibly add HIVE or HBD logos next to them.
For the USD value that makes sense; we could render a matching value next to each component.

I'd put them on the right side, at the top. I think it is fine that the data is also duplicated inside the collapsed property window (which few people will ever look at anyways).

We need to determine which balances to display and in which order. I'll find out what Clive shows as a first guess and post here shortly.

I'm not sure if this is the best list, but it's what clive shows:

Balance Type	Amount
HBD Liquid	6.578
HBD Savings	0.000
HBD Unclaimed	0.000
HIVE Liquid	109.639
HIVE Savings	0.000
HIVE Unclaimed	0.000

Thanks! I guess it would also make sense to add HP data (owned, received, delegated, powering down)

Not sure how much space this will consume when rendered, we will take a shot at the display and then discuss best placement for full screen and responsive

I'd probably skip received/delegated, because these tokens aren't really owned at all. I would show those values in the "voting box" similar to the way that hiveblocks.com did it.

If I recall correctly, for the voting bar, hiveblocks.com did it something like: HP + HP(received) - HP(delegated) = HP(voting power)

With the first HP being the actual HP of the account.

Of course, received and delegated only optionally were shown in the case where appropriate delegations existed.

(roadscape was really good at block explorer UIs, no one has yet matched him IMO).

Yes makes sense. I agree, hiveblocks was the go-to with its simplistic UI, I'm hoping hafbe would be the go-to for the future.

hey @dan what do you think of the below for now?

since there's a lot of data it wouldn't fit just under the name, so we made an "always open" section for it just below the voting section. We could try and move this above, but it would take some real estate from the filtering section, and not sure we want to do that. If you'd like to draft some layout ideas we can look into it.

Few additional notes as well for your feedback:

we are using global dynamic props feedprice to convert HIVE-HP/USD which could diverge from market value. We could alternatively use a different approach to this, either 3rd party or a witness feed price.
we are converting HBD to 1$ value. We could also use HBD price via 3rd party.

Thoughts?

It all looks good to me. I think your choices for pricing were also correct.

mentioned in merge request !368 (merged)

I was about to write separate issue, but it looks like it is really an extension to this one.

One of the annoyances in all places that display balances is that none display "special balances", so certain operations cause user assets to "disappear from view". These are the following:

open orders
unfinished escrow transfers
pending conversions
pending saving withdrawals

Those balances should be shown as well (as sums, so f.e. all orders to sell HIVE should be clumped together as one HIVE balance etc.). There should also be a total value as a sum of all assets of particular type. General idea is that asset should remain visible on user balance (and total should not change) until operation is finalized (so f.e. conversion from HBD to HIVE should remain as part of HBD in pending conversions balance until it triggers and becomes part of HIVE liquid balance). This way when user performs an operation on the asset, it just moves from one visible balance to the other until it changes to other asset or becomes part of some other user balance.

hey @ABW , sounds like a nice suggestion.

Maybe in the current wallet box, we could have an extended toggle that would show additional details you mentioned above, including open orders, pending withdrawals, conversions and escrow

I was considering adding total profile value (in USD) as well, but adding total value in HIVE and HBD might require some change to current layout or create a small summary section.

If you have layout (or additional) suggestions feel free to share

Happy to hear @dan thoughts as well

In theory, most of these should be shown. The most questionable is escrow sent because typically it should not come back (but a display of pending incoming could separately be nice to see). But the larger problem is I don't think we have haf api methods yet for this data so we would first need to add support for balance tracker to track and report it.

The existing hived API has these functions to get the data you'd need to compute them:

database_api.find_limit_orders(account_name) -> returns an array of objects that contain:
  limit_order_id_type id;
  time_point_sec      created;
  time_point_sec      expiration;
  account_name_type   seller;
  uint32_t            orderid;
  share_type          for_sale;
  price               sell_price;

database_api.find_hbd_conversion_requests(account_name): returns an array of objects that contain:
  convert_request_id_type id;
  account_name_type       owner;
  uint32_t                requestid;
  asset                   amount;
  time_point_sec          conversion_date;

database_api.find_collateralized_conversion_requests(account_name): returns an array of objects that contain:
  collateralized_convert_request_id_type id;
  account_name_type                      owner;
  uint32_t                               requestid;
  asset                                  collateral_amount;
  asset                                  converted_amount;
  time_point_sec                         conversion_date;

database_api.find_savings_withdrawals(account_name): returns an array of objects that contain
  savings_withdraw_id_type   id;
  account_name_type          from;
  account_name_type          to;
  string                     memo;
  uint32_t                   request_id = 0;
  asset                      amount;
  time_point_sec             complete;
  
database_api.find_escrows(account_name): returns an array of objects that contain:
  escrow_id_type    id;
  uint32_t          escrow_id;
  account_name_type from;
  account_name_type to;
  account_name_type agent;
  time_point_sec    ratification_deadline;
  time_point_sec    escrow_expiration;
  asset             hbd_balance;
  asset             hive_balance;
  asset             pending_fee;
  bool              to_approved;
  bool              agent_approved;
  bool              disputed;

But using those would increase the load on hived, so might want to wait until haf or btracker supports them

Yeah, my feeling is we should wait till we can implement in btracker, as we've got plenty of other improvements we can make to hafbe UI in the meantime. But I need to raise this issue with @bwrona , just in case it is harder to add to btracker than I'm thinking. If it is, we could consider using the functions above.

These will be added to btracker, here's the issue to track when it is done: balance_tracker#21 . There's several items already in the queue for our HAF backend guys (fix some existing issues with balance_tracker apis, hivemind performance improvement) so it will be a while before any from blocktrades team could tackle it and I'm not sure there's anyone else out there who will be willing to volunteer in the meantime.

Ok, quick followup, mcfarhat's team is going to take a shot at the backend task.

added To Do label

mentioned in issue balance_tracker#21

Account balances should be displayed more prominently

Designs

Child items ...

Activity