Limit order changes
- It is nice that
fill_order
is presented with IDs, however it still can't be matched to limit_order_create
because the latter does not have that information - it needs to be supplemented (personally I wouldn't mind if ID
replaced expiration
).
-
limit_order_create
could be formatted better, f.e. <user1> wants to sell <asset1> for at least <asset2>, ID <order ID user1>
- Formatter for
fill_order
needs to be corrected, because now the sentence makes no sense. I propose <user1> paid <assetA> for <assetB> from <user2> (<order ID user1> -> <order ID user2>)
. Alternatively just replace for
with to
.
-
limit_order_cancelled
- replace Transfer
with Order
. I'm also pretty sure there should be was
and not were
since it describes sum of asset (singular).