Skip to content

Follow-up from "Draft: Extend request account creation functionality"

The following discussions from !10 (merged) should be addressed:

  • @mtyszczak started a discussion:

    Add type declarations for hive_keychain and peakvault. Remember they can be undefined.

  • @mtyszczak started a discussion:

    Should we really create a separate store just for one value?

  • @mtyszczak started a discussion:

    This logic should be hoisted to the parent component - not in this one

  • @mtyszczak started a discussion:

    Some functionality in this file can be shared with MetaMask Connector using components.

  • @mtyszczak started a discussion:

    Remove description here

  • @mtyszczak started a discussion:

    Rename this component to better match its purpose

  • @mtyszczak started a discussion:

    Move ui/ files to separate directories, e.g. ui/hive/ - Add this path to the linter if you want to lint them

  • @mtyszczak started a discussion:

    It would be best if components inside ui/ directory did not use app stores.

  • @mtyszczak started a discussion:

    Try to find similar icons in @mdi/js

Edited by Fabian Waszkiewicz