Skip to content
Snippets Groups Projects

fix: add missing 'posting_json_metadata' field in Account interface

Merged Sergio requested to merge fix/add-missing-account-metadata-field into master
1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Did you test the library after adding it?

    • Author Developer

      I've not been able to successfully run the unit tests. Plenty of errors even before my change. But I cloned the repository, built locally and imported into another project with this:

      package.json:

      ...
      "@hiveio/dhive": "file:../dhive",
      ...

      And it worked. Actually it worked even before my change, but now I don't have a warning about the missing property.

    • Author Developer

      Let me know if I have to do something different as this is the first time I push code to dhive :)

    • It's fine as long as it works. Sometimes things break even with simple changes. Tests need a testnet node and that's why we can't keep them working forever. We just fixed them last hardfork.

    • Please register or sign in to reply
  • merged

  • Mahdi Yari mentioned in commit 0ac8de20

    mentioned in commit 0ac8de20

Please register or sign in to reply
Loading