fix: remove cache fallback that allowed different app versions

Dan Notesteinrequested to merge
fix/remove-smart-cache-fallback into develop

Summary

Fixes a bug in .haf_app_smart_cache_lookup that allowed using cached data from different app versions when AUTO_SKIP_SYNC=true.

When only CI config (.gitlab-ci.yml) changed, the detect_changes job would set AUTO_SKIP_SYNC=true. The smart cache lookup would then search for ANY app cache with matching HAF commit, ignoring the app commit. This caused schema incompatibility issues because the old cache could be missing schemas added in newer app versions.

Example failure: reputation_tracker tests failed with schema "reptracker_account_dump" does not exist because the cache from an older app version didn't have this schema.

Changes

  • Removed the fallback logic that searched for caches with different app commits
  • Cache lookup now only accepts exact key match (HAF_COMMIT + app commit) or falls back to HAF-only cache and runs sync
  • Updated comments to clarify this behavior

Merge request reports