Skip to content

Try again when there is an exception when sending request

Mateusz Żebrak requested to merge mzebrak/savings-no-response-from-node into develop

2 issues were discovered with the latest MR of !122 (merged).

  1. There are direct API calls in SavingsDataProvider not surrounded by CommunicationFailureNotificator exception handler (like we do one the Commands module) -> so if there is a communicationerror ever raised - app will crash instead of showing a notification.

  2. (THIS MR) - In the communication module, there were no retirees in some situations.

This should be enough to release %Second release , and 1st. issue need more attention - will handle it in another MR (There should be Command created for that like UpdateNodeData, and no direct API calls should be done in the provider.

Edited by Mateusz Żebrak

Merge request reports