Skip to content
Snippets Groups Projects

Lbudginas/#483 interactions tab bug

Merged Lukas Budginas requested to merge lbudginas/#483_interactions_tab_bug into develop

#483 (closed)

  • This is tricky bug, because first time interactions are loaded, if we go back to comments sections and select same permlink, it's already loaded, so loading indicator doesn't show up and because initial data is undefined (before we get permlink and accountName) , we can see no results before actual results, so IMO if there are no loading process and there are no data, we shouldn't show No Results , because it messes up the logic. We should show No Results when search is performed and we get no results out of this search. If we want to show something on UI before search is performed, we could create some other component to inform user that he could search for comments by permlink on this tab (which is already obvious).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading