From 143134910db644cb159e1f3e60f1d76e8eebc485 Mon Sep 17 00:00:00 2001
From: ABW <andrzejl@syncad.com>
Date: Wed, 4 Nov 2020 15:35:55 +0100
Subject: [PATCH] [ABW]: added negative tests for get_follow_count

---
 .../get_follow_count/bad_account.orig.json    |  5 ++++
 .../get_follow_count/bad_account.pat.json     |  5 ++++
 .../get_follow_count/bad_account.tavern.yaml  | 30 +++++++++++++++++++
 .../get_follow_count/empty_account.orig.json  |  5 ++++
 .../get_follow_count/empty_account.pat.json   |  5 ++++
 .../empty_account.tavern.yaml                 | 30 +++++++++++++++++++
 .../get_follow_count/no_account.orig.json     |  5 ++++
 .../get_follow_count/no_account.pat.json      |  5 ++++
 .../get_follow_count/no_account.tavern.yaml   | 30 +++++++++++++++++++
 .../get_content/_readme.txt                   | 10 ++++---
 .../get_content_replies/_readme.txt           |  6 ++--
 .../get_follow_count/_readme.txt              |  2 +-
 12 files changed, 131 insertions(+), 7 deletions(-)
 create mode 100644 hivemind/tavern/condenser_api_negative/get_follow_count/bad_account.orig.json
 create mode 100644 hivemind/tavern/condenser_api_negative/get_follow_count/bad_account.pat.json
 create mode 100644 hivemind/tavern/condenser_api_negative/get_follow_count/bad_account.tavern.yaml
 create mode 100644 hivemind/tavern/condenser_api_negative/get_follow_count/empty_account.orig.json
 create mode 100644 hivemind/tavern/condenser_api_negative/get_follow_count/empty_account.pat.json
 create mode 100644 hivemind/tavern/condenser_api_negative/get_follow_count/empty_account.tavern.yaml
 create mode 100644 hivemind/tavern/condenser_api_negative/get_follow_count/no_account.orig.json
 create mode 100644 hivemind/tavern/condenser_api_negative/get_follow_count/no_account.pat.json
 create mode 100644 hivemind/tavern/condenser_api_negative/get_follow_count/no_account.tavern.yaml

diff --git a/hivemind/tavern/condenser_api_negative/get_follow_count/bad_account.orig.json b/hivemind/tavern/condenser_api_negative/get_follow_count/bad_account.orig.json
new file mode 100644
index 00000000..7bac2901
--- /dev/null
+++ b/hivemind/tavern/condenser_api_negative/get_follow_count/bad_account.orig.json
@@ -0,0 +1,5 @@
+{
+  "code": -32602,
+  "data": "account not found: `nonexisting`",
+  "message": "Invalid parameters"
+}
diff --git a/hivemind/tavern/condenser_api_negative/get_follow_count/bad_account.pat.json b/hivemind/tavern/condenser_api_negative/get_follow_count/bad_account.pat.json
new file mode 100644
index 00000000..bec552d6
--- /dev/null
+++ b/hivemind/tavern/condenser_api_negative/get_follow_count/bad_account.pat.json
@@ -0,0 +1,5 @@
+{
+  "code": -32602,
+  "data": "Account nonexisting does not exist",
+  "message": "Invalid parameters"
+}
diff --git a/hivemind/tavern/condenser_api_negative/get_follow_count/bad_account.tavern.yaml b/hivemind/tavern/condenser_api_negative/get_follow_count/bad_account.tavern.yaml
new file mode 100644
index 00000000..f2ec38e0
--- /dev/null
+++ b/hivemind/tavern/condenser_api_negative/get_follow_count/bad_account.tavern.yaml
@@ -0,0 +1,30 @@
+---
+  test_name: Hivemind condenser_api.get_follow_count
+
+  marks:
+    - patterntest
+    - negative
+
+  includes:
+    - !include ../../common.yaml
+
+  stages:
+    - name: get_follow_count
+      request:
+        url: "{service.proto:s}://{service.server:s}:{service.port}/"
+        method: POST
+        headers:
+          content-type: application/json
+        json:
+          jsonrpc: "2.0"
+          id: 1
+          method: "condenser_api.get_follow_count"
+          params: {"account":"nonexisting"}
+      response:
+        status_code: 200
+        verify_response_with:
+          function: validate_response:compare_response_with_pattern
+          extra_kwargs:
+            method: "bad_account"
+            directory: "condenser_api_negative/get_follow_count"
+            error_response: true
diff --git a/hivemind/tavern/condenser_api_negative/get_follow_count/empty_account.orig.json b/hivemind/tavern/condenser_api_negative/get_follow_count/empty_account.orig.json
new file mode 100644
index 00000000..d6fea406
--- /dev/null
+++ b/hivemind/tavern/condenser_api_negative/get_follow_count/empty_account.orig.json
@@ -0,0 +1,5 @@
+{
+  "code": -32602,
+  "data": "invalid account (not specified)",
+  "message": "Invalid parameters"
+}
diff --git a/hivemind/tavern/condenser_api_negative/get_follow_count/empty_account.pat.json b/hivemind/tavern/condenser_api_negative/get_follow_count/empty_account.pat.json
new file mode 100644
index 00000000..d6fea406
--- /dev/null
+++ b/hivemind/tavern/condenser_api_negative/get_follow_count/empty_account.pat.json
@@ -0,0 +1,5 @@
+{
+  "code": -32602,
+  "data": "invalid account (not specified)",
+  "message": "Invalid parameters"
+}
diff --git a/hivemind/tavern/condenser_api_negative/get_follow_count/empty_account.tavern.yaml b/hivemind/tavern/condenser_api_negative/get_follow_count/empty_account.tavern.yaml
new file mode 100644
index 00000000..896c04c0
--- /dev/null
+++ b/hivemind/tavern/condenser_api_negative/get_follow_count/empty_account.tavern.yaml
@@ -0,0 +1,30 @@
+---
+  test_name: Hivemind condenser_api.get_follow_count
+
+  marks:
+    - patterntest
+    - negative
+
+  includes:
+    - !include ../../common.yaml
+
+  stages:
+    - name: get_follow_count
+      request:
+        url: "{service.proto:s}://{service.server:s}:{service.port}/"
+        method: POST
+        headers:
+          content-type: application/json
+        json:
+          jsonrpc: "2.0"
+          id: 1
+          method: "condenser_api.get_follow_count"
+          params: {"account":""}
+      response:
+        status_code: 200
+        verify_response_with:
+          function: validate_response:compare_response_with_pattern
+          extra_kwargs:
+            method: "empty_account"
+            directory: "condenser_api_negative/get_follow_count"
+            error_response: true
diff --git a/hivemind/tavern/condenser_api_negative/get_follow_count/no_account.orig.json b/hivemind/tavern/condenser_api_negative/get_follow_count/no_account.orig.json
new file mode 100644
index 00000000..8501b1d0
--- /dev/null
+++ b/hivemind/tavern/condenser_api_negative/get_follow_count/no_account.orig.json
@@ -0,0 +1,5 @@
+{
+  "code": -32602,
+  "data": "'account' parameter lacking default value",
+  "message": "Invalid parameters"
+}
diff --git a/hivemind/tavern/condenser_api_negative/get_follow_count/no_account.pat.json b/hivemind/tavern/condenser_api_negative/get_follow_count/no_account.pat.json
new file mode 100644
index 00000000..a9190fad
--- /dev/null
+++ b/hivemind/tavern/condenser_api_negative/get_follow_count/no_account.pat.json
@@ -0,0 +1,5 @@
+{
+  "code": -32602,
+  "data": "missing a required argument: 'account'",
+  "message": "Invalid parameters"
+}
diff --git a/hivemind/tavern/condenser_api_negative/get_follow_count/no_account.tavern.yaml b/hivemind/tavern/condenser_api_negative/get_follow_count/no_account.tavern.yaml
new file mode 100644
index 00000000..37557492
--- /dev/null
+++ b/hivemind/tavern/condenser_api_negative/get_follow_count/no_account.tavern.yaml
@@ -0,0 +1,30 @@
+---
+  test_name: Hivemind condenser_api.get_follow_count
+
+  marks:
+    - patterntest
+    - negative
+
+  includes:
+    - !include ../../common.yaml
+
+  stages:
+    - name: get_follow_count
+      request:
+        url: "{service.proto:s}://{service.server:s}:{service.port}/"
+        method: POST
+        headers:
+          content-type: application/json
+        json:
+          jsonrpc: "2.0"
+          id: 1
+          method: "condenser_api.get_follow_count"
+          params: {}
+      response:
+        status_code: 200
+        verify_response_with:
+          function: validate_response:compare_response_with_pattern
+          extra_kwargs:
+            method: "no_account"
+            directory: "condenser_api_negative/get_follow_count"
+            error_response: true
diff --git a/hivemind/tavern/condenser_api_patterns/get_content/_readme.txt b/hivemind/tavern/condenser_api_patterns/get_content/_readme.txt
index bb17cabb..97ae9692 100644
--- a/hivemind/tavern/condenser_api_patterns/get_content/_readme.txt
+++ b/hivemind/tavern/condenser_api_patterns/get_content/_readme.txt
@@ -1,13 +1,15 @@
 Gives content for given post.
+Current version gives output matching that of old Fat Node (database_api style posts). Original get_content output
+is still available through tags_api.get_discussion
 
 method: "condenser_api.get_content"
 params:
 {
-  "account": "{account}", "permlink": {permlink},
+  "author": "{author}", "permlink": {permlink},
   
-     mandatory, points to valid post
+    author + permlink : mandatory, points to valid post
 
-   "observer": "{account}",
+  "observer": "{account}"
 
-     optional, used for muted votes and blacklists
+    optional, used for muted votes and blacklists
 }
diff --git a/hivemind/tavern/condenser_api_patterns/get_content_replies/_readme.txt b/hivemind/tavern/condenser_api_patterns/get_content_replies/_readme.txt
index 310bcf77..bd3fc9a7 100644
--- a/hivemind/tavern/condenser_api_patterns/get_content_replies/_readme.txt
+++ b/hivemind/tavern/condenser_api_patterns/get_content_replies/_readme.txt
@@ -1,9 +1,11 @@
 Lists replies for given post.
+Current version gives output matching that of old Fat Node (database_api style posts). Original get_content_replies output
+is still available through tags_api.get_content_replies
 
 method: "condenser_api.get_content_replies"
 params:
 {
-  "author": "{author}", "permlink": {permlink},
+  "author": "{author}", "permlink": {permlink}
   
-     mandatory, points to valid post
+    author + permlink : mandatory, points to valid post
 }
diff --git a/hivemind/tavern/condenser_api_patterns/get_follow_count/_readme.txt b/hivemind/tavern/condenser_api_patterns/get_follow_count/_readme.txt
index 547aebad..697613d1 100644
--- a/hivemind/tavern/condenser_api_patterns/get_follow_count/_readme.txt
+++ b/hivemind/tavern/condenser_api_patterns/get_follow_count/_readme.txt
@@ -5,6 +5,6 @@ params:
 {
   "account":"{account}",
 
-     mandatory, point on valid account
+    mandatory, points to valid account
 
 }
\ No newline at end of file
-- 
GitLab