From 1e51376f133abd8cbaad998aa15b411df3f72a4d Mon Sep 17 00:00:00 2001
From: Bartek Wrona <wrona@syncad.com>
Date: Fri, 21 Mar 2025 19:45:35 +0100
Subject: [PATCH] Eliminated var assignments inside assertion statement
---
package/test_tools/__private/executable.py | 3 ++-
package/test_tools/__private/node.py | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/test_tools/__private/executable.py b/package/test_tools/__private/executable.py
index 47c3562c1..9fae5a903 100644
--- a/package/test_tools/__private/executable.py
+++ b/package/test_tools/__private/executable.py
@@ -43,7 +43,8 @@ class Executable:
def get_version(self) -> dict[str, Any]:
assert self.executable_name == "hived", "version can only be checked for hived binary!"
- assert isinstance(result := json.loads(self.__run_and_get_output("--version")), dict)
+ result = json.loads(self.__run_and_get_output("--version"))
+ assert isinstance(result, dict)
return result
def __run_and_get_output(self, *arguments: str) -> str:
diff --git a/package/test_tools/__private/node.py b/package/test_tools/__private/node.py
index d9fa99a3d..c3b994bce 100644
--- a/package/test_tools/__private/node.py
+++ b/package/test_tools/__private/node.py
@@ -115,7 +115,8 @@ class Node(BaseNode, ScopedObject):
@property
def http_endpoint(self) -> HttpUrl:
- assert (endpoint := self.__notifications.handler.http_endpoint) is not None
+ endpoint = self.__notifications.handler.http_endpoint
+ assert endpoint is not None
return endpoint
@http_endpoint.setter
--
GitLab