From 402806b7a0c206b5e9bcf50443e7cfae16daa6a5 Mon Sep 17 00:00:00 2001
From: Dan Notestein <dan@syncad.com>
Date: Thu, 5 Aug 2021 21:10:32 +0000
Subject: [PATCH] [DLN] JussiInternal errors aren't always an http request,
don't try to access log_traceback parameter when no http request. Comment out
Gerlock's unfinished code that would report timing of a RequestTimeoutError
and a ResponseTimeoutError
---
jussi/errors.py | 31 ++++++++++++++++++-------------
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/jussi/errors.py b/jussi/errors.py
index 64865d3..01ab0bc 100644
--- a/jussi/errors.py
+++ b/jussi/errors.py
@@ -127,7 +127,10 @@ class JussiInteralError(Exception):
self.jsonrpc_request = jrpc_request
self.jsonrpc_response = jrpc_response
self.exception = exception
- self.log_traceback = http_request.app.config.args.log_traceback
+ if http_request:
+ self.log_traceback = http_request.app.config.args.log_traceback
+ else:
+ self.log_traceback = False
self.logger = error_logger or logger
self.kwargs = kwargs
@@ -271,12 +274,13 @@ class RequestTimeoutError(JsonRpcError):
def to_dict(self):
data = super().to_dict()
- try:
- timings = self.timings()
- if timings:
- data.update(**timings)
- except Exception as e:
- logger.info('error adding timing data to RequestTimeoutError', e=e)
+ #Apparently unfinished code, there is no timings() function, should be fixed later I guess
+ #try:
+ # timings = self.timings()
+ # if timings:
+ # data.update(**timings)
+ #except Exception as e:
+ # logger.info('error adding timing data to RequestTimeoutError', e=e)
return data
@@ -286,12 +290,13 @@ class ResponseTimeoutError(JsonRpcError):
def to_dict(self):
data = super().to_dict()
- try:
- timings = self.timings()
- if timings:
- data.update(**timings)
- except Exception as e:
- logger.info('error adding timing data to RequestTimeoutError', e=e)
+ #Apparently unfinished code, there is no timings() function, should be fixed later I guess
+ #try:
+ # timings = self.timings()
+ # if timings:
+ # data.update(**timings)
+ #except Exception as e:
+ # logger.info('error adding timing data to RequestTimeoutError', e=e)
return data
--
GitLab