Skip to content

added handling for pre-rebranding names of fields of selected operations

Andrzej Lisak requested to merge incoming_transaction_condenser_fix into master

For now change only tested manually under debugger.

Transactions coming to condenser_api::broadcast_transaction[_synchronous] are repacked from JSON to legacy_signed_transaction and further to signed_transaction to be sent to network_broadcast_api. That repacking caused problem when old tool (using pre-rebranding field names in operations) sent transaction to post_rebranding node. The rebranded names could not be found in incoming JSON leaving them in default state which in turn caused either operation validation failure or authorization failure.

The fix adds code that tries to look for alternative (old) names of operation fields in case current (rebranded) name was not found in JSON. Only four operations were affected (there are other operations, but they are virtual ops, only for reading).

Note that reading from new node will still only return values with rebranded names.

Merge request reports