Skip to content

Fixes for !332 and some other vop related changes

Andrzej Lisak requested to merge abw_fix_mr332 into develop

Needs tests_api!248 (merged) and schemas!12 (merged)

It started as mild fixes for recently merged !332 (merged) however it turned out more changes are needed:

  • new dhf_instant_conversion_operation removed since its meaning became exactly the same as existing sps_convert_operation; old vop used instead
  • sps_convert_operation and sps_fund_operation renamed for dhf_conversion_operation and dhf_funding_operation respectively
  • in above vops fund_account renamed treasury like in all other places
  • in dgpo sps_fund_percent renamed proposal_fund_percent and sps_interval_ledger renamed dhf_interval_ledger
  • all files and classes with SPS in name now use DHF instead
  • fixed legacy vops in condenser_api (some were missing, some did not have proper definitions), although it seems like we could remove them all, since it looks like related visitor class is only used in connection with transactions, which means vops are never touched

Additionally:

  • added system_warning_operation for changes in max allowed block (we might want to also add one for changes in HBD interest rate if that does not happen too frequently)
  • fixed #321 (closed)
Edited by Andrzej Lisak

Merge request reports