hive issueshttps://gitlab.syncad.com/hive/hive/-/issues2022-08-25T22:25:33Zhttps://gitlab.syncad.com/hive/hive/-/issues/250HIVE_STATIC_BUILD=ON vs OFF review the actual difference2022-08-25T22:25:33ZGandalfHIVE_STATIC_BUILD=ON vs OFF review the actual differenceSeems like `HIVE_STATIC_BUILD` is <b>`OFF`</b> is default, but I always explicitly use <b>`ON`</b><br>
(that way I have portable binaries as served at https://gtg.openhive.network/get/bin/)
What's the actual difference?<br>
`libsnappy`, ...Seems like `HIVE_STATIC_BUILD` is <b>`OFF`</b> is default, but I always explicitly use <b>`ON`</b><br>
(that way I have portable binaries as served at https://gtg.openhive.network/get/bin/)
What's the actual difference?<br>
`libsnappy`, `libpthread`, `libreadline`?<br>
How about making it <b>`ON`</b> by default? (and actually getting rid of the switch entirely?)Mariusz TrelaMariusz Trelahttps://gitlab.syncad.com/hive/hive/-/issues/549Building hived without liburing-dev2023-07-24T14:13:56ZGandalfBuilding hived without liburing-devI was able to successfully build current develop of hived without having liburing-dev package.<br>
What's the potential impact? Will it silently affect rocksdb performance?I was able to successfully build current develop of hived without having liburing-dev package.<br>
What's the potential impact? Will it silently affect rocksdb performance?Mateusz TyszczakMateusz Tyszczakhttps://gitlab.syncad.com/hive/hive/-/issues/452Potential threadsafety issue in hive::protocol forward_compacted2023-01-30T14:39:54ZMateusz TyszczakPotential threadsafety issue in hive::protocol forward_compactedWhile searching for possible optimization for the new binary operation type in the haf repository, I encountered the function with the name: `run_all_visitor_overloads`, which uses the [`used_operations`](https://gitlab.syncad.com/hive/h...While searching for possible optimization for the new binary operation type in the haf repository, I encountered the function with the name: `run_all_visitor_overloads`, which uses the [`used_operations`](https://gitlab.syncad.com/hive/hive/-/blob/develop/libraries/protocol/forward_impacted.cpp#L521) variable.
@mkrzeminski do you have any information on the threadsafety of this approach and possibly write or perform tests confirming that?
The mentioned function is called by Postgres, which may create concurrent function calls.Maciej KrzeminskiMaciej Krzeminskihttps://gitlab.syncad.com/hive/hive/-/issues/433Loading snapshot generated by old incompatible version doesn't warn about it2023-05-17T15:01:02ZGandalfLoading snapshot generated by old incompatible version doesn't warn about itHuman error: I've loaded snapshot `latest` which is an obviously non-unique name.<br>
I've used new hived for a snapshot generated by old version, ended up with:
```
2022-12-05T12:29:31.449 state_snapshot_plugin.cpp:795 load_converted_da...Human error: I've loaded snapshot `latest` which is an obviously non-unique name.<br>
I've used new hived for a snapshot generated by old version, ended up with:
```
2022-12-05T12:29:31.449 state_snapshot_plugin.cpp:795 load_converted_data ] No objects loaded from storage for index: `owner_authority_history_object'
2022-12-05T12:29:31.450 state_snapshot_plugin.cpp:842 perform_load ] Finished processing of SST file at path: `/home/hive/.hived/snapshot/latest/owner_authority_history_object/549366_571813.sst'
2022-12-05T12:29:31.544 state_snapshot_plugin.cpp:802 load_converted_data ] Loaded objects from range <32172977, 32697264> for index: `transaction_status_object'
2022-12-05T12:29:31.544 state_snapshot_support.hpp:390 doConversion ] Loading items <32172977, 32697264> from transaction_status_object
2022-12-05T12:29:31.568 state_snapshot_plugin.cpp:1280 safe_spawn_snapshot_ ] index description: transaction_status_object id: 32172977
terminate called after throwing an instance of 'fc::unhandled_exception'
```
Instead I would rather expect it to warn me that snapshot was created by incompatible version, similarly to what's the case with starting hived with incompatible shared memory file.<br>
Also maybe `--force-load` as equivalent of `--force-open`.https://gitlab.syncad.com/hive/hive/-/issues/426Why 'w' appear in job Failed #4208012022-12-15T20:21:31ZKrzysztof Mochockikmochocki@syncad.comWhy 'w' appear in job Failed #420801Job [#420801](https://gitlab.syncad.com/hive/hive/-/jobs/420801) failed for 3aaafc48beba269453937b205bd47e62e700b2cb:
why in serializatiopn there is whole alphabet? are we using base 36? [`0123456789abcdefghijklmnopqrstuvwxyz`](https:/...Job [#420801](https://gitlab.syncad.com/hive/hive/-/jobs/420801) failed for 3aaafc48beba269453937b205bd47e62e700b2cb:
why in serializatiopn there is whole alphabet? are we using base 36? [`0123456789abcdefghijklmnopqrstuvwxyz`](https://gitlab.syncad.com/hive/hive/blob/84fa7f602aecc96af0eb116f9565cddf845cb7af/libraries/fc/src/uint128.cpp#L147)Marek Kochanowiczmarek@syncad.comMarek Kochanowiczmarek@syncad.comhttps://gitlab.syncad.com/hive/hive/-/issues/402When using --stop-replay-at-block do we want to always stop?2022-10-23T00:38:08ZForkyWhen using --stop-replay-at-block do we want to always stop?I was doing some tests on replays of snapshots when looking at the --stop-replay-at-block found that if we use it and don't specify --exit-before-sync, then it will not stop actually, and will start the p2p plugin and hang (in my case I ...I was doing some tests on replays of snapshots when looking at the --stop-replay-at-block found that if we use it and don't specify --exit-before-sync, then it will not stop actually, and will start the p2p plugin and hang (in my case I had the block_log ahead of the replay state).
Returning true here will cause it to stop as far as I understood/tested:
https://gitlab.syncad.com/hive/hive/-/commit/009356d859cd273122ae84e11d5ed0d93357bfd7
Just need some forensic review from who knows the code more, just in case I missed something.https://gitlab.syncad.com/hive/hive/-/issues/117producer_reward virtual operation issued twice for the same block2021-11-23T17:50:36Zarcangeproducer_reward virtual operation issued twice for the same blockVirtual operation `producer_reward` is sometimes issued twice for the same block/producer.
Example: https://hiveblocks.com/b/51289083
![image](/uploads/fb7849e59640cf0bb7df0b2897399b49/image.png)
Here are a few more examples:
![image...Virtual operation `producer_reward` is sometimes issued twice for the same block/producer.
Example: https://hiveblocks.com/b/51289083
![image](/uploads/fb7849e59640cf0bb7df0b2897399b49/image.png)
Here are a few more examples:
![image](/uploads/142f8dc56b6243ef1239fc64f78de780/image.png)
This occurred 786 times till now.
Didn't find any triple or greater reward.Marcin SobczykMarcin Sobczyk