From 6a0dd40b76395e0b7aa8f3402ed42f7c8434aaf3 Mon Sep 17 00:00:00 2001 From: Dan Notestein Date: Sat, 20 Dec 2025 23:42:47 -0500 Subject: [PATCH] Fix boolean argument serialization appending empty string Boolean flags like --replay-blockchain should not have any value appended. Previously, the code would generate ['--replay-blockchain', ''] which caused hived to fail on startup. Now we check if the converted value is non-empty before appending, so boolean flags correctly produce just ['--replay-blockchain']. --- beekeepy/beekeepy/_executable/abc/arguments.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/beekeepy/beekeepy/_executable/abc/arguments.py b/beekeepy/beekeepy/_executable/abc/arguments.py index 78d01f49..06ab6596 100644 --- a/beekeepy/beekeepy/_executable/abc/arguments.py +++ b/beekeepy/beekeepy/_executable/abc/arguments.py @@ -109,7 +109,9 @@ class Arguments(PreconfiguredBaseModel): if isinstance(v, list) and len(v) == 0: continue cli_arguments.append(pattern.format(self.__convert_member_name_to_cli_value(k))) - cli_arguments.append(self.__convert_member_value_to_string(v)) + value_str = self.__convert_member_value_to_string(v) + if value_str: # Don't append empty strings (e.g., for boolean flags) + cli_arguments.append(value_str) return cli_arguments def process(self, *, with_prefix: bool = True) -> list[str]: -- GitLab