From 3cd4a921f23d6571aa735e4e801ec102906b0adc Mon Sep 17 00:00:00 2001
From: kmochocki <kmochocki@syncad.com>
Date: Mon, 10 Feb 2025 15:41:36 +0000
Subject: [PATCH] Remove redundant test and fix test_api_close_session
---
.../api_tests/test_api_close_session.py | 30 +++++--------------
1 file changed, 8 insertions(+), 22 deletions(-)
diff --git a/tests/beekeepy_test/handle/api_tests/test_api_close_session.py b/tests/beekeepy_test/handle/api_tests/test_api_close_session.py
index d417e67e..29ecc2fd 100644
--- a/tests/beekeepy_test/handle/api_tests/test_api_close_session.py
+++ b/tests/beekeepy_test/handle/api_tests/test_api_close_session.py
@@ -15,20 +15,19 @@ WRONG_TOKEN: Final[str] = "104fc637d5c32c271bdfdc366af5bfc8f977e2462b01877454cfd
def test_api_close_session(beekeeper: Beekeeper) -> None:
"""Test test_api_close_session will test beekeeper_api.close_session api call."""
- # ARRANGE & ACT
- beekeeper.api.close_session()
+ # ARRANGE
+ token = beekeeper.api.create_session(salt=beekeeper.session.token).token
+
+ # ACT
+ beekeeper.api.close_session(token=token)
# ASSERT
- close_log_entry = (
- '"id":0,"jsonrpc":"2.0","method":"beekeeper_api.close_session",'
- f'"params":{{"token":"{beekeeper.session.token}"}}'
- )
+ close_log_entry = '"id":0,"jsonrpc":"2.0","method":"beekeeper_api.close_session",' f'"params":{{"token":"{token}"}}'
with pytest.raises(
ErrorInResponseError,
- match=f"A session attached to {beekeeper.session.token} doesn't exist",
+ match=f"A session attached to {token} doesn't exist",
):
- beekeeper.api.close_session()
-
+ beekeeper.api.close_session(token=token)
assert checkers.check_for_pattern_in_file(
beekeeper.settings.ensured_working_directory / "stderr.log", close_log_entry
), "Log should have information about closing session with specific token created during create_session call."
@@ -51,19 +50,6 @@ def test_if_beekeeper_closes_after_last_session_termination(
), "Beekeeper should be closed after last session termination."
-def test_api_close_session_double(beekeeper: Beekeeper) -> None:
- """Test test_api_close_session will test possibility of double closing session."""
- # ARRANGE & ACT
- beekeeper.api.close_session()
-
- # ASSERT
- with pytest.raises(
- ErrorInResponseError,
- match=f"A session attached to {beekeeper.session.token} doesn't exist",
- ):
- beekeeper.api.close_session()
-
-
@pytest.mark.parametrize("create_session", [False, True], ids=["no_session_before", "in_other_session"])
def test_api_close_session_not_existing(create_session: bool, beekeeper: Beekeeper) -> None:
"""Test test_api_close_session_not_existing will test possibility of closing not existing session."""
--
GitLab