From 3d40f01725d90cbf88df5bc50640a61695df9f2e Mon Sep 17 00:00:00 2001
From: Bartek Wrona <bwrona@syncad.com>
Date: Tue, 6 Jan 2026 16:18:30 +0000
Subject: [PATCH] Fix Clang compilation issues

- asio.hpp: Use promise factory method instead of direct constructor
- rate_limiting.cpp: Make rate_limiting_group_impl destructor virtual

Fixes Clang errors to enable ClangBuildAnalyzer usage for build profiling.
---
 include/fc/asio.hpp           | 2 +-
 src/network/rate_limiting.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/fc/asio.hpp b/include/fc/asio.hpp
index 0cc2d8f..471531a 100644
--- a/include/fc/asio.hpp
+++ b/include/fc/asio.hpp
@@ -81,7 +81,7 @@ namespace asio {
      */
     template<typename AsyncReadStream, typename MutableBufferSequence>
     size_t read( AsyncReadStream& s, const MutableBufferSequence& buf ) {
-        promise<size_t>::ptr p(new promise<size_t>("fc::asio::read"));
+        promise<size_t>::ptr p = promise<size_t>::create("fc::asio::read");
         boost::asio::async_read( s, buf, detail::read_write_handler(p) );
         return p->wait();
     }
diff --git a/src/network/rate_limiting.cpp b/src/network/rate_limiting.cpp
index 38b8618..539a8f5 100644
--- a/src/network/rate_limiting.cpp
+++ b/src/network/rate_limiting.cpp
@@ -216,7 +216,7 @@ namespace fc
 
       rate_limiting_group_impl(uint32_t upload_bytes_per_second, uint32_t download_bytes_per_second,
                                uint32_t burstiness_in_seconds = 1);
-      ~rate_limiting_group_impl();
+      virtual ~rate_limiting_group_impl();
 
       virtual size_t readsome(boost::asio::ip::tcp::socket& socket, char* buffer, size_t length) override;
       virtual size_t readsome(boost::asio::ip::tcp::socket& socket, const std::shared_ptr<char>& buffer, size_t length, size_t offset) override;
-- 
GitLab