Blog: after voting, the vote arrow is a non-focusable <span> (vote can't be removed with the keyboard); slider vote popover has no accessible names and focuses the submit button first
Environment: https://denser.discuss.peerverity.info/blog, develop f3f40a77, Chrome, 2026-10-15, logged in as guest4test1 (posting key, hbauth). The slider was enabled by patching vesting_shares in the find_accounts response in the browser, because the account is below the 1,000,000 VESTS threshold (VOTE_WEIGHT_DROPDOWN_THRESHOLD).
Component: apps/blog/features/votes/votes-component.tsx. Related: #1178 (closed) (logged-out arrows, fixed), #844 (closed) (vote removal confirmation), #1083.
1. Voted state is not keyboard-accessible (with or without slider)
Steps
- Upvote or downvote a post.
- Tab to that post's vote arrows on the list.
Actual: Tab skips the voted arrow. Example on thekittygirl/moon-cake, downvoted: from the upvote button, Tab goes straight to the payout $26.29. The voted arrow renders as:
<span class="cursor-pointer" data-state="closed" data-testid="downvote-button"><svg class="lucide lucide-circle-arrow-down …"></svg></span>It has no <button>, tabindex, role or accessible name. The trigger of VoteRemovalDialog (l. ~167–191 upvote, ~276–300 downvote) is a <span> wrapping TooltipContainer, and this branch doesn't depend on enable_slider, so every logged-in user is affected.
Impact:
- A vote can't be removed with the keyboard.
- Screen readers don't see the element.
- The vote state and percentage ("Undo downvote (-100%)") exist only in the hover tooltip.
Expected:
- The trigger is a
<button type="button">, e.g.AlertDialogTrigger asChildon a button, reachable with Tab and opening the removal dialog with Enter/Space. - It has an accessible name that includes the state, e.g. "Remove your downvote (-100%)", or
aria-pressed="true"plus a name. - Focus returns to it when the dialog closes.
- #1178 (closed) says "Logged in, the arrows are buttons", but that is only true before voting.
2. Slider popover: missing accessible names
- The upvote and downvote arrows that open the popover (
button[aria-haspopup="dialog"]) and the submit button inside the popover have no accessible name: an SVG icon only, noaria-label. "Upvote"/"Downvote" is a tooltip, not linked to the button. [role=dialog]has no name, and[role=slider]has no name oraria-valuetext.- For a downvote, a screen reader announces "100" while the UI shows "-100%".
Expected:
- Name the buttons ("Upvote", "Downvote", "Submit upvote at 80%").
- Name the dialog and slider ("Upvote weight").
- Set
aria-valuetext, e.g. "-100%" for downvotes.
3. Slider popover: initial focus on the submit button
When the popover opens with Enter, focus lands on the submit (vote) button, not on the slider. Pressing Enter again immediately broadcasts the vote at the last used weight. There is no further confirmation, and with an hbauth session no signing prompt either. This is also true for a -100% downvote. It happened by accident during this test: a vote_operation with weight: -10000 was broadcast on thekittygirl/moon-cake (rshares 0).
Expected:
- Initial focus goes to the slider, so Tab is needed to reach the submit button.
- Consider a confirmation for downvotes.
What works
Slider keys: arrows ±1%, PageUp/PageDown and Shift+arrow ±10%, Home/End 1%/100%. The value is shown and exposed via aria-valuenow, the focus ring is visible, Esc closes and returns focus to the arrow, and the last weight is remembered.
Acceptance criteria
- A voted arrow (up/down, slider on/off) is reachable with Tab, opens the removal dialog with Enter/Space and exposes its state.
- Vote buttons, popover and slider have accessible names, and the downvote value is announced as negative.
- Opening the popover with the keyboard does not put focus on the submit button.