From ea0d4605310a6a58ce2e734b81da09db7a112592 Mon Sep 17 00:00:00 2001 From: Dan Notestein Date: Sat, 3 Jan 2026 16:51:48 -0500 Subject: [PATCH] Fix HAF_COMMIT variable inheritance in haf_commit_validation template Remove default empty value for HAF_COMMIT in template variables. Template defaults override global variables, so setting HAF_COMMIT='' in the template prevented apps from using their global HAF_COMMIT. --- templates/haf_app_testing.gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/templates/haf_app_testing.gitlab-ci.yml b/templates/haf_app_testing.gitlab-ci.yml index 1cab222..f7d1fa0 100644 --- a/templates/haf_app_testing.gitlab-ci.yml +++ b/templates/haf_app_testing.gitlab-ci.yml @@ -327,7 +327,8 @@ include: stage: build image: alpine:latest variables: - HAF_COMMIT: "" # Must be set by derived job + # HAF_COMMIT should come from global variables or be set in derived job + # Do NOT set a default here as it would override global variables HAF_INCLUDE_REF: "" # Should match the 'ref' in your HAF include HAF_SUBMODULE_PATH: "haf" # Path to HAF submodule before_script: -- GitLab